From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: alexander.deucher@amd.com, airlied@linux.ie, Rex.Zhu@amd.com,
        Jammy.Zhou@amd.com, JinHuiEric.Huang@amd.com, tom.stdenis@amd.com,
        funfunctor@folklore1984.net, vitaly.prosyak@amd.com,
        eric.yang2@amd.com, Young.Yang@amd.com, ray.huang@amd.com,
        dan.carpenter@oracle.com, Flora.Cui@amd.com, nils.wallmenius@gmail.com,
        Monk.Liu@amd.com, Qingqing.Wang@amd.com, Frank.Min@amd.com,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn
Subject: Re: [PATCH] drm/amd/powerplay: mark symbols static where possible
Date: Mon, 24 Oct 2016 22:51:07 +0200
Message-ID: <6582910.6C6abby7Jc@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1477126582-2906-1-git-send-email-baoyou.xie@linaro.org>
References: <1477126582-2906-1-git-send-email-baoyou.xie@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 650
Lines: 20

On Saturday, October 22, 2016 4:56:22 PM CEST Baoyou Xie wrote:
> @@ -1341,7 +1341,7 @@ int smu7_disable_dpm_tasks(struct pp_hwmgr *hwmgr)
>         return result;
>  }
>  
> -int smu7_reset_asic_tasks(struct pp_hwmgr *hwmgr)
> +static int smu7_reset_asic_tasks(struct pp_hwmgr *hwmgr)
>  {
>  
>         return 0;
> 

This needs to be done differently:

../drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:1344:12: error: 'smu7_reset_asic_tasks' defined but not used [-Werror=unused-function]

The function has no callers, so the easiest way would be to remove it
entirely, but it's possible that there are plans to add users soon.

	Arnd