Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757795AbcJXWIn (ORCPT ); Mon, 24 Oct 2016 18:08:43 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:58912 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757380AbcJXWIm (ORCPT ); Mon, 24 Oct 2016 18:08:42 -0400 X-Auth-Info: VNkil+BrjLY2v1MM5U1wwu1nRVyc27H5MBMGqfQrkZg= Subject: Re: [PATCH v3 1/9] mtd: spi-nor: improve macronix_quad_enable() To: Cyrille Pitchen , computersforpeace@gmail.com, linux-mtd@lists.infradead.org References: Cc: nicolas.ferre@atmel.com, boris.brezillon@free-electrons.com, richard@nod.at, linux-kernel@vger.kernel.org From: Marek Vasut Message-ID: <74f0fa1b-3212-8a21-f966-14f153d2bf43@denx.de> Date: Tue, 25 Oct 2016 00:00:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1250 Lines: 39 On 10/24/2016 06:34 PM, Cyrille Pitchen wrote: > The patch checks whether the Quad Enable bit is already set in the Status > Register. If so, the function exits immediately with a successful return > code. Otherwise, a message is now printed telling we're setting the > non-volatile bit. > > Signed-off-by: Cyrille Pitchen > Reviewed-by: Jagan Teki > --- > drivers/mtd/spi-nor/spi-nor.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index d0fc165d7d66..5c87b2d99507 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -1211,6 +1211,11 @@ static int macronix_quad_enable(struct spi_nor *nor) > val = read_sr(nor); > if (val < 0) > return val; > + if (val & SR_QUAD_EN_MX) > + return 0; > + > + /* Update the Quad Enable bit. */ > + dev_info(nor->dev, "setting Macronix Quad Enable (non-volatile) bit\n"); Should probably be dev_dbg(), since this is just churn in the kernel log. The user doesn't care and the developer can just up the debug level or add his own printk . > write_enable(nor); > > write_sr(nor, val | SR_QUAD_EN_MX); > -- Best regards, Marek Vasut