Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757864AbcJXXgI (ORCPT ); Mon, 24 Oct 2016 19:36:08 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33787 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754535AbcJXXgH (ORCPT ); Mon, 24 Oct 2016 19:36:07 -0400 Date: Mon, 24 Oct 2016 16:35:50 -0700 From: Dmitry Torokhov To: Dmitry Tunin Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Mathias Gottschlag Subject: Re: [PATCH] Input: psmouse - cleanup Focaltech code Message-ID: <20161024233550.GA9026@dtor-ws> References: <1475923136-6046-1-git-send-email-hanipouspilot@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475923136-6046-1-git-send-email-hanipouspilot@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1325 Lines: 44 On Sat, Oct 08, 2016 at 01:38:56PM +0300, Dmitry Tunin wrote: > psmouse->name "Focaltech Touchpad" is an overkill. In xinput it is too long as > "FocaltechPS/2 Focaltech Focaltech Touchpad" > > In focaltech_report_state() pointer to psmouse->dev is already stored as *dev > > Signed-off-by: Dmitry Tunin Applied, thank you. > --- > drivers/input/mouse/focaltech.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/mouse/focaltech.c b/drivers/input/mouse/focaltech.c > index c8c6a8c..49a56f655 100644 > --- a/drivers/input/mouse/focaltech.c > +++ b/drivers/input/mouse/focaltech.c > @@ -43,7 +43,7 @@ int focaltech_detect(struct psmouse *psmouse, bool set_properties) > > if (set_properties) { > psmouse->vendor = "FocalTech"; > - psmouse->name = "FocalTech Touchpad"; > + psmouse->name = "Touchpad"; > } > > return 0; > @@ -146,8 +146,8 @@ static void focaltech_report_state(struct psmouse *psmouse) > } > input_mt_report_pointer_emulation(dev, true); > > - input_report_key(psmouse->dev, BTN_LEFT, state->pressed); > - input_sync(psmouse->dev); > + input_report_key(dev, BTN_LEFT, state->pressed); > + input_sync(dev); > } > > static void focaltech_process_touch_packet(struct psmouse *psmouse, > -- > 2.7.4 > -- Dmitry