Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758000AbcJYAL1 (ORCPT ); Mon, 24 Oct 2016 20:11:27 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:36474 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755190AbcJYALZ (ORCPT ); Mon, 24 Oct 2016 20:11:25 -0400 Date: Mon, 24 Oct 2016 22:11:15 -0200 From: Mauro Carvalho Chehab To: Andrey Utkin Cc: SF Markus Elfring , linux-media@vger.kernel.org, Hans Verkuil , Laurent Pinchart , Mauro Carvalho Chehab , Rafael =?UTF-8?B?TG91cmVuw6dv?= de Lima Chehab , Shuah Khan , Wolfram Sang , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc() Message-ID: <20161024221115.3632aa5c@vento.lan> In-Reply-To: <20161024222844.GD25320@dell-m4800.home> References: <68ad1aaa-c029-04b9-805a-e859f6c2d2d5@users.sourceforge.net> <20161024222844.GD25320@dell-m4800.home> Organization: Samsung X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2198 Lines: 68 Em Mon, 24 Oct 2016 23:28:44 +0100 Andrey Utkin escreveu: > On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Mon, 24 Oct 2016 22:08:47 +0200 > > > > * Multiplications for the size determination of memory allocations > > indicated that array data structures should be processed. > > Thus use the corresponding function "kcalloc". > > > > This issue was detected by using the Coccinelle software. > > > > * Replace the specification of data types by pointer dereferences > > to make the corresponding size determination a bit safer according to > > the Linux coding style convention. > > > > Signed-off-by: Markus Elfring > > --- > > drivers/media/usb/au0828/au0828-video.c | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c > > index 85dd9a8..85b13c1 100644 > > --- a/drivers/media/usb/au0828/au0828-video.c > > +++ b/drivers/media/usb/au0828/au0828-video.c > > @@ -221,15 +221,18 @@ static int au0828_init_isoc(struct au0828_dev *dev, int max_packets, > > > > dev->isoc_ctl.isoc_copy = isoc_copy; > > dev->isoc_ctl.num_bufs = num_bufs; > > - > > > - dev->isoc_ctl.urb = kzalloc(sizeof(void *)*num_bufs, GFP_KERNEL); > > + dev->isoc_ctl.urb = kcalloc(num_bufs, > > + sizeof(*dev->isoc_ctl.urb), > > + GFP_KERNEL); > > What about this (for both hunks)? > > - dev->isoc_ctl.urb = kzalloc(sizeof(void *)*num_bufs, GFP_KERNEL); > + dev->isoc_ctl.urb = > + kcalloc(num_bufs, sizeof(*dev->isoc_ctl.urb), GFP_KERNEL); That's worse :) The usual Kernel style is: var = foo(bar1, bar2, bar3); instead of something like: var = foo(bar1, bar2, bar3); The places where it is different than that is because people ran ./scripts/Lindent to try to follow the Kernel coding style. On my experiences, at the end, using it caused more harm than good, IMHO, and cause very weird indentation on lines with more than 80 columns like the above. Thanks, Mauro