Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758115AbcJYAsQ (ORCPT ); Mon, 24 Oct 2016 20:48:16 -0400 Received: from vern.gendns.com ([206.190.152.46]:45398 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755257AbcJYAsL (ORCPT ); Mon, 24 Oct 2016 20:48:11 -0400 Subject: Re: [PATCH/RFT v2 17/17] ARM: dts: da850: add usb device node To: ahaslam@baylibre.com, gregkh@linuxfoundation.org, johan@kernel.org, robh+dt@kernel.org, nsekhar@ti.com, stern@rowland.harvard.edu, khilman@baylibre.com, sshtylyov@ru.mvista.com, manjunath.goudar@linaro.org, broonie@kernel.org, abailon@baylibre.com References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-18-ahaslam@baylibre.com> Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: David Lechner Message-ID: <59ca6a1f-6db9-eed2-8e8a-77657c7febac@lechnology.com> Date: Mon, 24 Oct 2016 19:48:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161024164634.4330-18-ahaslam@baylibre.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1681 Lines: 61 On 10/24/2016 11:46 AM, ahaslam@baylibre.com wrote: > From: Axel Haslam > > This adds the usb (ohci) device node for the da850 soc. > Also it enables it for the lcdk board > > Signed-off-by: Axel Haslam > --- > arch/arm/boot/dts/da850-lcdk.dts | 8 ++++++++ > arch/arm/boot/dts/da850.dtsi | 8 ++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts > index 7b8ab21..fa91339 100644 > --- a/arch/arm/boot/dts/da850-lcdk.dts > +++ b/arch/arm/boot/dts/da850-lcdk.dts > @@ -86,6 +86,14 @@ > }; > }; > > +&usb_phy { > + status = "okay"; > +}; > + > +&usb { > + status = "okay"; Don't you need to specify a regulator here using the vbus-supply property? > +}; > + > &serial2 { > pinctrl-names = "default"; > pinctrl-0 = <&serial2_rxtx_pins>; > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > index 33fcdce..ec2cec3 100644 > --- a/arch/arm/boot/dts/da850.dtsi > +++ b/arch/arm/boot/dts/da850.dtsi > @@ -381,6 +381,14 @@ > #phy-cells = <1>; > status = "disabled"; > }; > + usb: usb@0225000 { Don't need the leading 0 on usb@225000 The alias (usb:) might need to be more specific since there is a second usb device that will be added later for musb. (The comments in the previous review only referred to the "usb" in "usb@", not the alias.) > + compatible = "ti,da830-ohci"; > + reg = <0x225000 0x1000>; > + interrupts = <59>; > + phys = <&usb_phy 1>; > + phy-names = "usb-phy"; > + status = "disabled"; > + }; > gpio: gpio@226000 { > compatible = "ti,dm6441-gpio"; > gpio-controller; >