Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758095AbcJYAx6 (ORCPT ); Mon, 24 Oct 2016 20:53:58 -0400 Received: from vern.gendns.com ([206.190.152.46]:45678 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752600AbcJYAx4 (ORCPT ); Mon, 24 Oct 2016 20:53:56 -0400 Subject: Re: [PATCH/RFT v2 16/17] USB: ohci-da8xx: Allow probing from DT To: ahaslam@baylibre.com, gregkh@linuxfoundation.org, johan@kernel.org, robh+dt@kernel.org, nsekhar@ti.com, stern@rowland.harvard.edu, khilman@baylibre.com, sshtylyov@ru.mvista.com, broonie@kernel.org, abailon@baylibre.com References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-17-ahaslam@baylibre.com> Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: David Lechner Message-ID: Date: Mon, 24 Oct 2016 19:53:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161024164634.4330-17-ahaslam@baylibre.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1241 Lines: 44 On 10/24/2016 11:46 AM, ahaslam@baylibre.com wrote: > From: Axel Haslam > > This adds the compatible string to the ohci driver > to be able to probe from DT > > Signed-off-by: Axel Haslam > --- > drivers/usb/host/ohci-da8xx.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c > index bebc3f0..1a8db25 100644 > --- a/drivers/usb/host/ohci-da8xx.c > +++ b/drivers/usb/host/ohci-da8xx.c > @@ -273,6 +273,13 @@ static int ohci_da8xx_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, > } > > /*-------------------------------------------------------------------------*/ > +#ifdef CONFIG_OF #ifdef CONFIG_OF is probably not needed here... > +static const struct of_device_id da8xx_ohci_ids[] = { > + { .compatible = "ti,da830-ohci" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, da8xx_ohci_ids); > +#endif > > static int ohci_da8xx_probe(struct platform_device *pdev) > { > @@ -421,6 +428,7 @@ static int ohci_da8xx_resume(struct platform_device *dev) > #endif > .driver = { > .name = "ohci", > + .of_match_table = da8xx_ohci_ids, ...otherwise, da8xx_ohci_ids will not be defined here > }, > }; > >