Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941393AbcJYDlI (ORCPT ); Mon, 24 Oct 2016 23:41:08 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:41883 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbcJYDlB (ORCPT ); Mon, 24 Oct 2016 23:41:01 -0400 Date: Tue, 25 Oct 2016 11:40:06 +0800 From: Herbert Xu To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Jason Gunthorpe , Kevin Hilman , Neil Armstrong , PrasannaKumar Muralidharan , Carlo Caione , linux-amlogic@lists.infradead.org, Matt Mackall , linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH v2] hwrng: meson: Fix module autoload for OF registration Message-ID: <20161025034006.GD18685@gondor.apana.org.au> References: <1476733877-20275-1-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476733877-20275-1-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 937 Lines: 26 On Mon, Oct 17, 2016 at 04:51:17PM -0300, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias > alias: platform:meson-rng > > After this patch: > > $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias > alias: platform:meson-rng > alias: of:N*T*Camlogic,meson-rngC* > alias: of:N*T*Camlogic,meson-rng > > Signed-off-by: Javier Martinez Canillas Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt