Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758116AbcJYF5d (ORCPT ); Tue, 25 Oct 2016 01:57:33 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:51391 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbcJYF5c (ORCPT ); Tue, 25 Oct 2016 01:57:32 -0400 Subject: Re: [PATCH] advansys: fix build warning for PCI=n To: Arnd Bergmann , "James E.J. Bottomley" , "Martin K. Petersen" References: <20161024155207.3027347-1-arnd@arndb.de> Cc: Jens Axboe , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org From: Hannes Reinecke Message-ID: <16f7581f-0bdc-56ad-522e-12f3c4dc0828@suse.com> Date: Tue, 25 Oct 2016 07:57:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161024155207.3027347-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1807 Lines: 47 On 10/24/2016 05:51 PM, Arnd Bergmann wrote: > The advansys probe function tries to handle both ISA and PCI cases, > each hidden in an #ifdef when unused. This leads to a warning > indicating that when PCI is disabled we could be using uninitialized > data: > > drivers/scsi/advansys.c: In function ‘advansys_board_found’: > drivers/scsi/advansys.c:11036:5: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > drivers/scsi/advansys.c:10928:28: note: ‘ret’ was declared here > drivers/scsi/advansys.c:11309:8: error: ‘share_irq’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > drivers/scsi/advansys.c:10928:6: note: ‘share_irq’ was declared here > > This cannot happen in practice because the hardware in question > only exists for PCI, but changing the code to just error out > here is better for consistency and avoids the warning. > > Signed-off-by: Arnd Bergmann > --- > drivers/scsi/advansys.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c > index febbd83e2ecd..81dd0927246b 100644 > --- a/drivers/scsi/advansys.c > +++ b/drivers/scsi/advansys.c > @@ -11030,6 +11030,9 @@ static int advansys_board_found(struct Scsi_Host *shost, unsigned int iop, > ASC_DBG(2, "AdvInitGetConfig()\n"); > > ret = AdvInitGetConfig(pdev, shost) ? -ENODEV : 0; > +#else > + share_irq = 0; > + ret = -ENODEV; > #endif /* CONFIG_PCI */ > } > > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.com +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)