Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757535AbcJYGvE (ORCPT ); Tue, 25 Oct 2016 02:51:04 -0400 Received: from mga02.intel.com ([134.134.136.20]:62358 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753157AbcJYGu7 (ORCPT ); Tue, 25 Oct 2016 02:50:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,545,1473145200"; d="scan'208";a="1058683631" Subject: Re: [PATCH v2 RESEND] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers To: Babu Moger , Mathias Nyman , "gregkh@linuxfoundation.org" References: <1477088705-202225-1-git-send-email-babu.moger@oracle.com> <580DDB16.5030906@linux.intel.com> <80d710fc-a30f-b661-7ca3-f3df9d020c30@oracle.com> Cc: Yoshihiro Shimoda , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Mathias Nyman Message-ID: <580F00DE.9030508@intel.com> Date: Tue, 25 Oct 2016 09:51:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <80d710fc-a30f-b661-7ca3-f3df9d020c30@oracle.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1091 Lines: 32 On 24.10.2016 17:52, Babu Moger wrote: > > On 10/24/2016 5:54 AM, Yoshihiro Shimoda wrote: >> Hi, >> >>> From: Mathias Nyman >>> Sent: Monday, October 24, 2016 6:58 PM >>> >>> On 22.10.2016 01:25, Babu Moger wrote: >>>> Never seen XHCI auto handoff working on TI and RENESAS cards. >>>> Eventually, we force handoff. This code forces the handoff >>>> unconditionally. It saves 5 seconds boot time for each card. >>>> >>>> Signed-off-by: Babu Moger >>> Do the Renesas and TI controllers still advertise the extended capability >>> for the handoff? (XHCI_EXT_CAPS_LEGACY) > I don't see this capability. Here is lspci output. > It's not a PCI capability, it's a xhci Extended Capability. If the capability is supported, and handoff fail, then quirk_usb_handoff_xhci() will print "xHCI BIOS handoff failed (BIOS bug ?)" Further on in the same function we wait for the "controller not ready" bit in the status register to clear. If that times it prints out: "xHCI HW not ready after 5 sec (HC bug?) status" Do you see any of these two messages in the log? -Mathias