Date: Tue, 25 Oct 2016 09:47:46 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Stuart Yoder <stuart.yoder@nxp.com>
Cc: german.rivera@nxp.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, agraf@suse.de, arnd@arndb.de,
        leoyang.li@nxp.com
Subject: Re: [PATCH 11/14] staging: fsl-mc: message cleanup
Message-ID: <20161025074746.GC22581@kroah.com>
References: <1476729819-10219-1-git-send-email-stuart.yoder@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1476729819-10219-1-git-send-email-stuart.yoder@nxp.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 824
Lines: 21

On Mon, Oct 17, 2016 at 01:43:39PM -0500, Stuart Yoder wrote:
> Cleanup and clarify messages
>   -use "fsl-mc" prefix for all messages that don't come from dev_*
>    functions

Nope, please use the proper pr_fmt() #define at the top of the file,
that way you don't have to put the string into all pr_* calls.

>   -remove unnecessary verbosity to make things clearer
>   -use explicit __func__ arguments to clarify some error messages
>   -improve misc wording for clarity

That's alot of different things.  Again, if you have to list the
different things you do in a patch, that means you should break it up
into smaller ones.  Yes, this is a "tiny" patch, but I can't take it
because of the above problem, while if you had broken it up into smaller
ones, I could have taken all but the pr_* changes :(

thanks,

greg k-h