Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758548AbcJYILC (ORCPT ); Tue, 25 Oct 2016 04:11:02 -0400 Received: from mail-qk0-f182.google.com ([209.85.220.182]:36956 "EHLO mail-qk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754908AbcJYIK7 (ORCPT ); Tue, 25 Oct 2016 04:10:59 -0400 MIME-Version: 1.0 In-Reply-To: References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-17-ahaslam@baylibre.com> From: Axel Haslam Date: Tue, 25 Oct 2016 10:10:17 +0200 Message-ID: Subject: Re: [PATCH/RFT v2 16/17] USB: ohci-da8xx: Allow probing from DT To: David Lechner Cc: Greg KH , Johan Hovold , robh+dt@kernel.org, Sekhar Nori , Alan Stern , Kevin Hilman , Sergei Shtylyov , Mark Brown , Alexandre Bailon , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1517 Lines: 56 On Tue, Oct 25, 2016 at 2:53 AM, David Lechner wrote: > On 10/24/2016 11:46 AM, ahaslam@baylibre.com wrote: >> >> From: Axel Haslam >> >> This adds the compatible string to the ohci driver >> to be able to probe from DT >> >> Signed-off-by: Axel Haslam >> --- >> drivers/usb/host/ohci-da8xx.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c >> index bebc3f0..1a8db25 100644 >> --- a/drivers/usb/host/ohci-da8xx.c >> +++ b/drivers/usb/host/ohci-da8xx.c >> @@ -273,6 +273,13 @@ static int ohci_da8xx_hub_control(struct usb_hcd >> *hcd, u16 typeReq, u16 wValue, >> } >> >> >> /*-------------------------------------------------------------------------*/ >> +#ifdef CONFIG_OF > > > #ifdef CONFIG_OF is probably not needed here... > >> +static const struct of_device_id da8xx_ohci_ids[] = { >> + { .compatible = "ti,da830-ohci" }, >> + { } >> +}; >> +MODULE_DEVICE_TABLE(of, da8xx_ohci_ids); >> +#endif >> >> static int ohci_da8xx_probe(struct platform_device *pdev) >> { >> @@ -421,6 +428,7 @@ static int ohci_da8xx_resume(struct platform_device >> *dev) >> #endif >> .driver = { >> .name = "ohci", >> + .of_match_table = da8xx_ohci_ids, > > > ...otherwise, da8xx_ohci_ids will not be defined here this should be .of_match_table = of_match_ptr(da8xx_ohci_ids), will fix. > >> }, >> }; >> >> >