Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758566AbcJYIlG (ORCPT ); Tue, 25 Oct 2016 04:41:06 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:25728 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756288AbcJYIlC (ORCPT ); Tue, 25 Oct 2016 04:41:02 -0400 Date: Tue, 25 Oct 2016 11:40:32 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: linux-media@vger.kernel.org, Hans Verkuil , Laurent Pinchart , Mauro Carvalho Chehab , Rafael =?iso-8859-1?Q?Louren=E7o?= de Lima Chehab , Shuah Khan , Wolfram Sang , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc() Message-ID: <20161025084031.GF4469@mwanda> References: <68ad1aaa-c029-04b9-805a-e859f6c2d2d5@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <68ad1aaa-c029-04b9-805a-e859f6c2d2d5@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 226 Lines: 9 On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote: > + dev->isoc_ctl.transfer_buffer = kcalloc(num_bufs, > + sizeof(*dev->isoc_ctl > + .transfer_buffer), This is ugly. regards, dan carpenter