Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758457AbcJYIsk (ORCPT ); Tue, 25 Oct 2016 04:48:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40982 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755975AbcJYIsh (ORCPT ); Tue, 25 Oct 2016 04:48:37 -0400 Date: Tue, 25 Oct 2016 10:48:43 +0200 From: Greg KH To: Nadim Almas Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging:wlan-ng:hfa384x: fixed 80 character line limit coding style issue Message-ID: <20161025084843.GA5727@kroah.com> References: <20161021124232.GA4398@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161021124232.GA4398@gmail.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1280 Lines: 39 On Fri, Oct 21, 2016 at 06:12:32PM +0530, Nadim Almas wrote: > Fixed coding style issue > > Signed-off-by: Nadim Almas > --- > drivers/staging/wlan-ng/hfa384x.h | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h > index 6337b1d..cca2652 100644 > --- a/drivers/staging/wlan-ng/hfa384x.h > +++ b/drivers/staging/wlan-ng/hfa384x.h > @@ -1349,7 +1349,9 @@ struct hfa384x { > * interface > */ > > - struct hfa384x_caplevel cap_act_sta_mfi; /* sta f/w to modem interface */ > + struct hfa384x_caplevel cap_act_sta_mfi; /* > + * sta f/w to modem interface > + */ > > struct hfa384x_caplevel cap_act_ap_cfi; /* > * ap f/w to controller > @@ -1371,7 +1373,9 @@ struct hfa384x { > > struct hfa384x_inf_frame *scanresults; > > - struct prism2sta_authlist authlist; /* Authenticated station list. */ > + struct prism2sta_authlist authlist; /* > + * Authenticated station list > + */ These changes really don't make things more readable, do they? Put the comment above the variable if you really care, or just don't worry about the 1 or 2 characters over the line-length limit here. thanks, greg k-h