Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758594AbcJYIuz (ORCPT ); Tue, 25 Oct 2016 04:50:55 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:53158 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756957AbcJYIuw (ORCPT ); Tue, 25 Oct 2016 04:50:52 -0400 MIME-Version: 1.0 In-Reply-To: References: <20161020034344.14154-1-wens@csie.org> <20161020034344.14154-9-wens@csie.org> From: Chen-Yu Tsai Date: Tue, 25 Oct 2016 16:50:25 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 8/8] ARM: dts: sun6i: hummingbird-a31: Enable display output through VGA bridge To: Archit Taneja Cc: Chen-Yu Tsai , Maxime Ripard , David Airlie , Rob Herring , Mark Rutland , dri-devel , linux-arm-kernel , linux-kernel , devicetree , linux-sunxi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3322 Lines: 111 On Tue, Oct 25, 2016 at 4:13 PM, Archit Taneja wrote: > > > On 10/20/2016 09:13 AM, Chen-Yu Tsai wrote: >> >> The Hummingbird A31 board has a RGB-to-VGA bridge which converts RGB >> output from the LCD interface to VGA signals. >> >> Enable this part of the display pipeline. > > > I couldn't find the enable-gpios binding for the bridge that you > introduced in the previous patch. Is that intentional? Error on my part. Thanks for spotting that. ChenYu > > Thanks, > Archit > > >> >> Signed-off-by: Chen-Yu Tsai >> --- >> arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 56 >> +++++++++++++++++++++++++++++ >> 1 file changed, 56 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun6i-a31-hummingbird.dts >> b/arch/arm/boot/dts/sun6i-a31-hummingbird.dts >> index 9a74637f677f..05a49b2147f1 100644 >> --- a/arch/arm/boot/dts/sun6i-a31-hummingbird.dts >> +++ b/arch/arm/boot/dts/sun6i-a31-hummingbird.dts >> @@ -63,6 +63,49 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> + bridge { >> + compatible = "dumb-vga-dac"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0>; >> + >> + vga_bridge_in: endpoint@0 { >> + reg = <0>; >> + remote-endpoint = >> <&tcon0_out_vga>; >> + }; >> + }; >> + >> + port@1 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <1>; >> + >> + vga_bridge_out: endpoint@0 { >> + reg = <0>; >> + remote-endpoint = <&vga_con_in>; >> + }; >> + }; >> + }; >> + }; >> + >> + vga { >> + compatible = "vga-connector"; >> + >> + port { >> + vga_con_in: endpoint { >> + remote-endpoint = <&vga_bridge_out>; >> + }; >> + }; >> + }; >> + >> wifi_pwrseq: wifi_pwrseq { >> compatible = "mmc-pwrseq-simple"; >> reset-gpios = <&pio 6 10 GPIO_ACTIVE_LOW>; /* PG10 */ >> @@ -245,6 +288,19 @@ >> status = "okay"; >> }; >> >> +&tcon0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&lcd0_rgb888_pins>; >> + status = "okay"; >> +}; >> + >> +&tcon0_out { >> + tcon0_out_vga: endpoint@0 { >> + reg = <0>; >> + remote-endpoint = <&vga_bridge_in>; >> + }; >> +}; >> + >> &uart0 { >> pinctrl-names = "default"; >> pinctrl-0 = <&uart0_pins_a>; >> > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project