Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758632AbcJYIw5 (ORCPT ); Tue, 25 Oct 2016 04:52:57 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:12861 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755823AbcJYIwb (ORCPT ); Tue, 25 Oct 2016 04:52:31 -0400 Subject: Re: [PATCH v3 1/9] mtd: spi-nor: improve macronix_quad_enable() To: Marek Vasut , , References: <74f0fa1b-3212-8a21-f966-14f153d2bf43@denx.de> CC: , , , From: Cyrille Pitchen Message-ID: <6948ab96-62ab-c383-4f50-e897be0999b3@atmel.com> Date: Tue, 25 Oct 2016 10:52:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <74f0fa1b-3212-8a21-f966-14f153d2bf43@denx.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.145.133.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1504 Lines: 47 Hi Marek, Le 25/10/2016 à 00:00, Marek Vasut a écrit : > On 10/24/2016 06:34 PM, Cyrille Pitchen wrote: >> The patch checks whether the Quad Enable bit is already set in the Status >> Register. If so, the function exits immediately with a successful return >> code. Otherwise, a message is now printed telling we're setting the >> non-volatile bit. >> >> Signed-off-by: Cyrille Pitchen >> Reviewed-by: Jagan Teki >> --- >> drivers/mtd/spi-nor/spi-nor.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c >> index d0fc165d7d66..5c87b2d99507 100644 >> --- a/drivers/mtd/spi-nor/spi-nor.c >> +++ b/drivers/mtd/spi-nor/spi-nor.c >> @@ -1211,6 +1211,11 @@ static int macronix_quad_enable(struct spi_nor *nor) >> val = read_sr(nor); >> if (val < 0) >> return val; >> + if (val & SR_QUAD_EN_MX) >> + return 0; >> + >> + /* Update the Quad Enable bit. */ >> + dev_info(nor->dev, "setting Macronix Quad Enable (non-volatile) bit\n"); > > Should probably be dev_dbg(), since this is just churn in the kernel > log. The user doesn't care and the developer can just up the debug level > or add his own printk . > The Quad Enable bit is non-volatile so this trace should be printed only once but I'm perfectly fine with using dev_dbg(). I'll change it in the next version. Best regards, Cyrille >> write_enable(nor); >> >> write_sr(nor, val | SR_QUAD_EN_MX); >> > >