Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941547AbcJYJMW (ORCPT ); Tue, 25 Oct 2016 05:12:22 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:17697 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941548AbcJYJMT (ORCPT ); Tue, 25 Oct 2016 05:12:19 -0400 Date: Tue, 25 Oct 2016 12:11:58 +0300 From: Dan Carpenter To: Ivan Safonov Cc: Greg Kroah-Hartman , Bhaktipriya Shridhar , Andy Shevchenko , Geliang Tang , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/37] staging:r8188eu: remove debug messages after memory allocation failed Message-ID: <20161025091157.GH4469@mwanda> References: <1476889685-7367-1-git-send-email-insafonov@gmail.com> <1476889685-7367-13-git-send-email-insafonov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476889685-7367-13-git-send-email-insafonov@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 469 Lines: 13 On Wed, Oct 19, 2016 at 10:07:41PM +0700, Ivan Safonov wrote: > These messages are redundant. > Also break rtw_usb_if1_init function if HalData allocation failed. > > Signed-off-by: Ivan Safonov Since you're redoing this anyway, please split this one into two patches. We really frown on mixing bugfixes with cleanups. I wasn't frowning on it enough to ask you to redo the series but since you're already doing that... regards, dan carpenter