Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965739AbcJYKb7 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Oct 2016 06:31:59 -0400
Received: from mail-qk0-f182.google.com ([209.85.220.182]:33893 "EHLO
        mail-qk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965691AbcJYKb4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Oct 2016 06:31:56 -0400
MIME-Version: 1.0
In-Reply-To: <522eeb9a-6fb1-88eb-5c58-7ee209a50fc3@ti.com>
References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-9-ahaslam@baylibre.com>
 <522eeb9a-6fb1-88eb-5c58-7ee209a50fc3@ti.com>
From: Axel Haslam <ahaslam@baylibre.com>
Date: Tue, 25 Oct 2016 12:31:14 +0200
Message-ID: <CAKXjFTOFG+o=mpbZ4ixkh8nm+oipx8+nbr0FduCPzJVuXOc0RQ@mail.gmail.com>
Subject: Re: [PATCH/RFT v2 08/17] ARM: davinci: hawk: add full constraints for
 ohci plat boot
To: Sekhar Nori <nsekhar@ti.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, Johan Hovold <johan@kernel.org>,
        robh+dt@kernel.org, Alan Stern <stern@rowland.harvard.edu>,
        Kevin Hilman <khilman@baylibre.com>,
        Sergei Shtylyov <sshtylyov@ru.mvista.com>,
        David Lechner <david@lechnology.com>, manjunath.goudar@linaro.org,
        Mark Brown <broonie@kernel.org>,
        Alexandre Bailon <abailon@baylibre.com>, linux-usb@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1031
Lines: 32

On Tue, Oct 25, 2016 at 12:28 PM, Sekhar Nori <nsekhar@ti.com> wrote:
> On Monday 24 October 2016 10:16 PM, ahaslam@baylibre.com wrote:
>> From: Axel Haslam <ahaslam@baylibre.com>
>>
>> The phy framework requests an optional "phy" regulator. If it does
>> not find one, it returns -EPROBE_DEFER. In the case of non-DT based boot
>> for the omap138-lcdk board, this would prevent the usb11 phy to probe
>> correctly and ohci would not enumerate.
>>
>> By calling "regulator_has_full_constraints", An error would be returned
>
> nit: prefer regulator_has_full_constraints()
>
>> instead of DEFER for the "optional" regulator, and the probe of
>> the phy driver can continue normally without a regulator.
>>
>> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
>
> Looks good to me. Just drop the "hawk: from subject line since you also
> touch da830 evm. I am not sure what "ohci plat boot" means. How about
> the following:
>
> "ARM: davinci: da8xx: fix OHCI PHY probe for non-DT boot"
>

Will do.

Thanks
Axel.

> Thanks,
> Sekhar