Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965763AbcJYK4E (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Oct 2016 06:56:04 -0400
Received: from mailapp01.imgtec.com ([195.59.15.196]:50956 "EHLO
        mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965563AbcJYK4C (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Oct 2016 06:56:02 -0400
Date: Tue, 25 Oct 2016 11:55:49 +0100
From: "Maciej W. Rozycki" <macro@imgtec.com>
To: Paul Burton <paul.burton@imgtec.com>
CC: <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>,
        <devicetree@vger.kernel.org>, Stephan Linz <linz@li-pro.net>,
        Jacek Anaszewski <j.anaszewski@samsung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 11/14] MIPS: Malta: Use syscon-reboot driver to
 reboot
In-Reply-To: <2861325.0K2k6plxiD@np-p-burton>
Message-ID: <alpine.DEB.2.00.1610251003330.31859@tp.orcam.me.uk>
References: <20160919212132.28893-1-paul.burton@imgtec.com> <20160919212132.28893-12-paul.burton@imgtec.com> <alpine.DEB.2.00.1610220956020.31859@tp.orcam.me.uk> <2861325.0K2k6plxiD@np-p-burton>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-Originating-IP: [10.20.78.214]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1115
Lines: 34

Hi Paul,

> >  This has broken reboot support, all I get now is:
> > 
> > reboot: Restarting system
> > Unable to restart system
> > Reboot failed -- System halted
> > 
> > at which point I need to issue a serial BREAK to regain control of the
> > board and get back to YAMON; fortunately the board is wired for that.
> 
> This was already reported over here:
> 
> https://www.linux-mips.org/archives/linux-mips/2016-10/msg00120.html 
> 
> These 2 patches fix it:
> 
> https://patchwork.linux-mips.org/patch/14395/ 
> https://patchwork.linux-mips.org/patch/14396/ 

 Thanks, good to know and sorry to raise a late alarm then.

 As it happens the board I've been fiddling with has been temporarily 
sitting idle, so I went ahead and verified that these changes have indeed 
removed the regression in my configuration.  So you've got a confirmation 
from a real Malta hardware user now too (QEMU may have its own quirks).

> I've asked Ralf if we can get those, along with a few others, in ASAP - 
> preferrably for -rc3.

 As these are fixes to a functional regression I also recommend merging 
them ASAP.

  Maciej