Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756595AbcJYLMz (ORCPT ); Tue, 25 Oct 2016 07:12:55 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:32807 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751905AbcJYLMy (ORCPT ); Tue, 25 Oct 2016 07:12:54 -0400 Date: Tue, 25 Oct 2016 13:10:18 +0200 (CEST) From: Thomas Gleixner To: Dave Airlie cc: mcgrof@suse.com, torvalds@linux-foundation.org, dan.j.williams@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Toshi Kani , Borislav Petkov , "H. Peter Anvin" , Andy Lutomirski , Denys Vlasenko , Brian Gerst Subject: Re: [PATCH 1/2] x86/io: add interface to reserve io memtype for a resource range. (v1.1) In-Reply-To: <1477290706-7696-2-git-send-email-airlied@redhat.com> Message-ID: References: <1477290706-7696-1-git-send-email-airlied@redhat.com> <1477290706-7696-2-git-send-email-airlied@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 490 Lines: 17 On Mon, 24 Oct 2016, Dave Airlie wrote: > A recent change to the mm code in: > 87744ab3832b83ba71b931f86f9cfdb000d07da5 nit: 12 digits of the SHA1 are sufficient :) > +int arch_io_reserve_memtype_wc(resource_size_t start, resource_size_t size) > +{ > + enum page_cache_mode type = _PAGE_CACHE_MODE_WC; Empty line between variable declaration and code please > + return io_reserve_memtype(start, start + size, &type); Other than that: Reviewed-by: Thomas Gleixner