Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965839AbcJYMnU (ORCPT ); Tue, 25 Oct 2016 08:43:20 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:40787 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941735AbcJYMnS (ORCPT ); Tue, 25 Oct 2016 08:43:18 -0400 MIME-Version: 1.0 In-Reply-To: <1477396919-27669-3-git-send-email-binoy.jayan@linaro.org> References: <1477396919-27669-1-git-send-email-binoy.jayan@linaro.org> <1477396919-27669-3-git-send-email-binoy.jayan@linaro.org> From: Jack Wang Date: Tue, 25 Oct 2016 14:43:15 +0200 Message-ID: Subject: Re: [PATCH v2 2/8] IB/core: Replace semaphore sm_sem with completion To: Binoy Jayan Cc: Doug Ledford , Sean Hefty , Hal Rosenstock , Arnd Bergmann , "linux-rdma@vger.kernel.org" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 331 Lines: 18 Hi Binoy, snip > > port->ib_dev = device; > port->port_num = port_num; > - sema_init(&port->sm_sem, 1); > + init_completion(&port->sm_comp); > + complete(&port->sm_comp); Why complete here? > mutex_init(&port->file_mutex); > INIT_LIST_HEAD(&port->file_list); > > -- KR, Jinpu