Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965893AbcJYMqX (ORCPT ); Tue, 25 Oct 2016 08:46:23 -0400 Received: from mail-vk0-f45.google.com ([209.85.213.45]:33384 "EHLO mail-vk0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941721AbcJYMqT (ORCPT ); Tue, 25 Oct 2016 08:46:19 -0400 MIME-Version: 1.0 In-Reply-To: <5098701.SVmQeRIiho@wuerfel> References: <1477396919-27669-1-git-send-email-binoy.jayan@linaro.org> <1477396919-27669-9-git-send-email-binoy.jayan@linaro.org> <5098701.SVmQeRIiho@wuerfel> From: Binoy Jayan Date: Tue, 25 Oct 2016 18:16:17 +0530 Message-ID: Subject: Re: [PATCH v2 8/8] IB/mlx5: Add helper mlx5_ib_post_send_wait To: Arnd Bergmann Cc: Doug Ledford , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, Linux kernel mailing list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 753 Lines: 21 On 25 October 2016 at 17:53, Arnd Bergmann wrote: > On Tuesday, October 25, 2016 5:31:59 PM CEST Binoy Jayan wrote: > Looks reasonable. Thank you Arnd for looking at it again. > Did you get a warning about 'bad' being unused here? I would have > guessed not, since the original code was not that different and > it does get passed into a function. I remembered getting a warning like that, but when i remove the unused attribute now, it does not. It was probably a side effect of some other error. Will change it. > Why not move the umr_context variable into this function too? > The only thing we ever seem to do to is initialize it and > assign the wr_cqe pointer, both of which can be done here. I guess it could be done. Binoy