Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759108AbcJYNKk (ORCPT ); Tue, 25 Oct 2016 09:10:40 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:19337 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757921AbcJYNKi (ORCPT ); Tue, 25 Oct 2016 09:10:38 -0400 Subject: Re: [PATCH v2 RESEND] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers To: Mathias Nyman , Mathias Nyman , "gregkh@linuxfoundation.org" References: <1477088705-202225-1-git-send-email-babu.moger@oracle.com> <580DDB16.5030906@linux.intel.com> <80d710fc-a30f-b661-7ca3-f3df9d020c30@oracle.com> <580F00DE.9030508@intel.com> Cc: Yoshihiro Shimoda , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Babu Moger Organization: Oracle Corporation Message-ID: Date: Tue, 25 Oct 2016 08:10:24 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <580F00DE.9030508@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1307 Lines: 43 On 10/25/2016 1:51 AM, Mathias Nyman wrote: > On 24.10.2016 17:52, Babu Moger wrote: >> >> On 10/24/2016 5:54 AM, Yoshihiro Shimoda wrote: >>> Hi, >>> >>>> From: Mathias Nyman >>>> Sent: Monday, October 24, 2016 6:58 PM >>>> >>>> On 22.10.2016 01:25, Babu Moger wrote: >>>>> Never seen XHCI auto handoff working on TI and RENESAS cards. >>>>> Eventually, we force handoff. This code forces the handoff >>>>> unconditionally. It saves 5 seconds boot time for each card. >>>>> >>>>> Signed-off-by: Babu Moger >>>> Do the Renesas and TI controllers still advertise the extended >>>> capability >>>> for the handoff? (XHCI_EXT_CAPS_LEGACY) >> I don't see this capability. Here is lspci output. >> > > It's not a PCI capability, it's a xhci Extended Capability. > > If the capability is supported, and handoff fail, then > quirk_usb_handoff_xhci() will print > "xHCI BIOS handoff failed (BIOS bug ?)" > Yes. I see these messages. After this patch I don't see these messages. > Further on in the same function we wait for the "controller not ready" > bit in the status > register to clear. If that times it prints out: > > "xHCI HW not ready after 5 sec (HC bug?) status" No. I didn't see this messages. > > Do you see any of these two messages in the log? > > -Mathias