Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965952AbcJYN3K (ORCPT ); Tue, 25 Oct 2016 09:29:10 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:40911 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932474AbcJYN3J (ORCPT ); Tue, 25 Oct 2016 09:29:09 -0400 Message-ID: <1477402145.4332.11.camel@gmail.com> Subject: Re: [PATCH] serial: core: fix console problems on uart_close From: Mike Galbraith To: Rob Herring Cc: Geert Uytterhoeven , Greg Kroah-Hartman , Niklas =?ISO-8859-1?Q?S=F6derlund?= , Mugunthan V N , Geert Uytterhoeven , "linux-kernel@vger.kernel.org" , Peter Hurley , Alan Cox , Jiri Slaby , "linux-serial@vger.kernel.org" Date: Tue, 25 Oct 2016 15:29:05 +0200 In-Reply-To: References: <20161024205649.32430-1-robh@kernel.org> <1477400150.4332.9.camel@gmail.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1281 Lines: 29 On Tue, 2016-10-25 at 08:25 -0500, Rob Herring wrote: > On Tue, Oct 25, 2016 at 7:55 AM, Mike Galbraith > wrote: > > On Tue, 2016-10-25 at 12:40 +0200, Geert Uytterhoeven wrote: > > > > > Mike: I see you are using a PC, while I'm using an ARM board (with DT). > > > Are you using a serial console? If yes, what's the value of port->console > > > before and after the call to uart_console() that Rob's patch below removes? > > > > Well, it's a bit larger than the average PC, it's a 64 core HP DL980, > > and my console is its virtual serial port. > > > > [ 15.217487] Serial: 8250/16550 driver, 32 ports, IRQ sharing disabled > > [ 15.228212] MIKE port:ffff880276400000 port->console:0 > > [ 15.240889] MIKE port:ffff880276400000 port->console:0 > > [ 15.269606] 00:03: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A > > [ 15.282538] MIKE port:ffff8802764001a8 port->console:0 > > [ 15.293195] MIKE port:ffff8802764001a8 port->console:1 > > [ 15.322806] serial8250: ttyS1 at I/O 0x2f8 (irq = 3, base_baud = 115200) is a 16550A > > (30 more calls, all 0 pre 0 post) > > > > That's with the below from Jiri Slaby applied to quell the reboot time > > explosion. > > This alone is enough to fix things for you? Yup. -Mike