Date: Tue, 25 Oct 2016 09:58:11 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: luca abeni <luca.abeni@unitn.it>
Cc: Daniel Bristot de Oliveira <bristot@redhat.com>,
        linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@arm.com>,
        Claudio Scordino <claudio@evidence.eu.com>
Subject: Re: [RFC v3 1/6] Track the active utilisation
Message-ID: <20161025095811.50a5856a@gandalf.local.home>
In-Reply-To: <20161025112916.67eb245c@utopia>
References: <1477317998-7487-1-git-send-email-luca.abeni@unitn.it>
        <1477317998-7487-2-git-send-email-luca.abeni@unitn.it>
        <de0b4be7-5481-e4c7-f1eb-298ebd677b8f@redhat.com>
        <20161025112916.67eb245c@utopia>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1027
Lines: 37

On Tue, 25 Oct 2016 11:29:16 +0200
luca abeni <luca.abeni@unitn.it> wrote:

> Hi Daniel,
> 
> On Tue, 25 Oct 2016 11:09:52 +0200
> Daniel Bristot de Oliveira <bristot@redhat.com> wrote:
> [...]
> > > +static void add_running_bw(struct sched_dl_entity *dl_se, struct
> > > dl_rq *dl_rq) +{
> > > +	u64 se_bw = dl_se->dl_bw;
> > > +
> > > +	dl_rq->running_bw += se_bw;
> > > +}    
> > 
> > why not...
> > 
> > static *inline*
> > void add_running_bw(struct sched_dl_entity *dl_se, struct dl_rq
> > *dl_rq) {
> > 	dl_rq->running_bw += dl_se->dl_bw;
> > }
> > 
> > am I missing something?  
> 
> I do not know... Maybe I am the one missing something :)
> I assumed that the compiler is smart enough to inline the function (and
> to avoid creating a local variable on the stack), but if there is
> agreement I can change the function in this way.
> 
> 

I agree with Daniel, especially since I don't usually trust the
compiler. And the added variable is more of a distraction as it doesn't
seem to have any real purpose.

-- Steve