Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758855AbcJYN6S (ORCPT ); Tue, 25 Oct 2016 09:58:18 -0400 Received: from smtprelay0123.hostedemail.com ([216.40.44.123]:60341 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756438AbcJYN6P (ORCPT ); Tue, 25 Oct 2016 09:58:15 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2906:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:5007:6119:6120:6261:7875:7903:8531:10004:10400:10848:10967:11026:11232:11658:11914:12296:12663:12740:12760:13069:13311:13357:13439:14096:14097:14180:14181:14659:14721:21060:21080:21434:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: car72_81f7c40a9cd60 X-Filterd-Recvd-Size: 2181 Date: Tue, 25 Oct 2016 09:58:11 -0400 From: Steven Rostedt To: luca abeni Cc: Daniel Bristot de Oliveira , linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Juri Lelli , Claudio Scordino Subject: Re: [RFC v3 1/6] Track the active utilisation Message-ID: <20161025095811.50a5856a@gandalf.local.home> In-Reply-To: <20161025112916.67eb245c@utopia> References: <1477317998-7487-1-git-send-email-luca.abeni@unitn.it> <1477317998-7487-2-git-send-email-luca.abeni@unitn.it> <20161025112916.67eb245c@utopia> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1027 Lines: 37 On Tue, 25 Oct 2016 11:29:16 +0200 luca abeni wrote: > Hi Daniel, > > On Tue, 25 Oct 2016 11:09:52 +0200 > Daniel Bristot de Oliveira wrote: > [...] > > > +static void add_running_bw(struct sched_dl_entity *dl_se, struct > > > dl_rq *dl_rq) +{ > > > + u64 se_bw = dl_se->dl_bw; > > > + > > > + dl_rq->running_bw += se_bw; > > > +} > > > > why not... > > > > static *inline* > > void add_running_bw(struct sched_dl_entity *dl_se, struct dl_rq > > *dl_rq) { > > dl_rq->running_bw += dl_se->dl_bw; > > } > > > > am I missing something? > > I do not know... Maybe I am the one missing something :) > I assumed that the compiler is smart enough to inline the function (and > to avoid creating a local variable on the stack), but if there is > agreement I can change the function in this way. > > I agree with Daniel, especially since I don't usually trust the compiler. And the added variable is more of a distraction as it doesn't seem to have any real purpose. -- Steve