Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965453AbcJYPou (ORCPT ); Tue, 25 Oct 2016 11:44:50 -0400 Received: from vern.gendns.com ([206.190.152.46]:45303 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965204AbcJYPoq (ORCPT ); Tue, 25 Oct 2016 11:44:46 -0400 Subject: Re: [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts To: Sekhar Nori , Kevin Hilman References: <1477075018-20176-1-git-send-email-david@lechnology.com> <1477075018-20176-6-git-send-email-david@lechnology.com> <1593441f-d147-4c91-8aab-8622dd8ced19@lechnology.com> <84648cb0-f1fa-d88b-bac2-79208af01ca6@lechnology.com> <0b7cf7a1-e234-2868-dfde-347c92c23829@ti.com> Cc: Rob Herring , Mark Rutland , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: David Lechner Message-ID: <565013e4-efbe-df79-a52f-329be51289c5@lechnology.com> Date: Tue, 25 Oct 2016 10:44:44 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <0b7cf7a1-e234-2868-dfde-347c92c23829@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1872 Lines: 52 On 10/25/2016 05:58 AM, Sekhar Nori wrote: > On Tuesday 25 October 2016 02:50 AM, David Lechner wrote: >> On 10/24/2016 02:50 PM, David Lechner wrote: >>> On 10/24/2016 10:50 AM, David Lechner wrote: >>>> On 10/24/2016 06:58 AM, Sekhar Nori wrote: >>>>> On Saturday 22 October 2016 12:06 AM, David Lechner wrote: >>>>> >>>>>> +&ehrpwm1 { >>>>>> + status = "disabled"; >>>>> >>>>> Hmm, disabled? Can you add this node when you actually use it? >>>> >>>> Not sure why I have this disabled. Like the gpios, the pwms can be used >>>> via sysfs, so I would like to leave them. >>>> >>> >>> Now I remember why these are disabled. The clock matching is broken. >>> Only the first ehrpwm and the first ecap get clocks. The others fail. >>> >>> I can change these to "okay". It will just result in a kernel error >>> message until the clocks are fixed. >>> >> >> correction: it is not the clocks that are broken. it is the device names. >> >> In arch/arm/mach-davinci/da8xx-dt.c, we have... >> >> >> OF_DEV_AUXDATA("ti,da850-ehrpwm", 0x01f00000, "ehrpwm", NULL), >> OF_DEV_AUXDATA("ti,da850-ehrpwm", 0x01f02000, "ehrpwm", NULL), >> OF_DEV_AUXDATA("ti,da850-ecap", 0x01f06000, "ecap", NULL), >> OF_DEV_AUXDATA("ti,da850-ecap", 0x01f07000, "ecap", NULL), >> OF_DEV_AUXDATA("ti,da850-ecap", 0x01f08000, "ecap", NULL), >> >> >> Which causes each device to have the same device node name. This causes >> sysfs errors because it is trying to register a second device at the >> same sysfs path. >> >> If you change the names here, then the device do not work because the >> clock lookup fails. > > Yeah, this is incorrect (I should have caught it in review). The device > id should have been present in the lookup. Can you fix auxdata and clock > lookup too and send a separate patch? Its probably a v4.9-rc candidate. > > Thanks, > Sekhar > Yes, I can do this.