Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758998AbcJYPrU (ORCPT ); Tue, 25 Oct 2016 11:47:20 -0400 Received: from mga03.intel.com ([134.134.136.65]:45908 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759092AbcJYPrS (ORCPT ); Tue, 25 Oct 2016 11:47:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,546,1473145200"; d="scan'208";a="893795595" Subject: Re: [RFC 1/8] mm: Define coherent device memory node To: Anshuman Khandual , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <1477283517-2504-1-git-send-email-khandual@linux.vnet.ibm.com> <1477283517-2504-2-git-send-email-khandual@linux.vnet.ibm.com> <580E4043.4090200@intel.com> <580EB3CB.5080200@linux.vnet.ibm.com> Cc: mhocko@suse.com, js1304@gmail.com, vbabka@suse.cz, mgorman@suse.de, minchan@kernel.org, akpm@linux-foundation.org, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com From: Dave Hansen Message-ID: <580F7E75.8080600@intel.com> Date: Tue, 25 Oct 2016 08:47:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <580EB3CB.5080200@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1452 Lines: 32 On 10/24/2016 06:22 PM, Anshuman Khandual wrote: > On 10/24/2016 10:39 PM, Dave Hansen wrote: >>> +#ifdef CONFIG_COHERENT_DEVICE >>>> +#define node_cdm(nid) (NODE_DATA(nid)->coherent_device) >>>> +#define set_cdm_isolation(nid) (node_cdm(nid) = 1) >>>> +#define clr_cdm_isolation(nid) (node_cdm(nid) = 0) >>>> +#define isolated_cdm_node(nid) (node_cdm(nid) == 1) >>>> +#else >>>> +#define set_cdm_isolation(nid) () >>>> +#define clr_cdm_isolation(nid) () >>>> +#define isolated_cdm_node(nid) (0) >>>> +#endif >> FWIW, I think adding all this "cdm" gunk in the names is probably a bad >> thing. >> >> I can think of other memory types that are coherent, but >> non-device-based that might want behavior like this. > > Hmm, I was not aware about non-device-based coherent memory. Could you > please name some of them ? If thats the case we need to change CDM to > some thing which can accommodate both device and non device based > coherent memory. May be like "Differentiated/special coherent memory". > But it needs to communicate that its not system RAM. Thats the idea. Intel has some stuff called MCDRAM. It's described in detail here: > https://software.intel.com/en-us/articles/mcdram-high-bandwidth-memory-on-knights-landing-analysis-methods-tools You can also Google around for more information. I believe Samsung has a technology called High Bandwidth Memory (HBM) that's already a couple of generations old that sounds similar.