Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758517AbcJYQFI (ORCPT ); Tue, 25 Oct 2016 12:05:08 -0400 Received: from vern.gendns.com ([206.190.152.46]:46324 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754958AbcJYQFF (ORCPT ); Tue, 25 Oct 2016 12:05:05 -0400 Subject: Re: [PATCH/RFT v2 07/17] ARM: davinci: da8xx: Enable the usb20 "per" clk on phy_clk_enable To: Sekhar Nori , ahaslam@baylibre.com, gregkh@linuxfoundation.org, johan@kernel.org, robh+dt@kernel.org, stern@rowland.harvard.edu, khilman@baylibre.com, sshtylyov@ru.mvista.com, manjunath.goudar@linaro.org, broonie@kernel.org, abailon@baylibre.com References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-8-ahaslam@baylibre.com> <833b6b60-4504-dac7-ccbb-bc08c985ad01@ti.com> Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: David Lechner Message-ID: <5abddbfe-0338-6406-9299-1d2d3fb957a3@lechnology.com> Date: Tue, 25 Oct 2016 11:05:02 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <833b6b60-4504-dac7-ccbb-bc08c985ad01@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1326 Lines: 41 On 10/25/2016 05:12 AM, Sekhar Nori wrote: > On Monday 24 October 2016 10:16 PM, ahaslam@baylibre.com wrote: >> diff --git a/arch/arm/mach-davinci/usb-da8xx.c b/arch/arm/mach-davinci/usb-da8xx.c >> index 9e41a7f..982e105 100644 >> --- a/arch/arm/mach-davinci/usb-da8xx.c >> +++ b/arch/arm/mach-davinci/usb-da8xx.c >> @@ -53,11 +53,19 @@ int __init da8xx_register_usb_refclkin(int rate) >> >> static void usb20_phy_clk_enable(struct clk *clk) >> { >> + struct clk *usb20_clk; >> u32 val; >> u32 timeout = 500000; /* 500 msec */ >> >> val = readl(DA8XX_SYSCFG0_VIRT(DA8XX_CFGCHIP2_REG)); >> >> + usb20_clk = clk_get(NULL, "usb20"); > > We should not be using a NULL device pointer here. Can you pass the musb > device pointer available in the same file? Also, da850_clks[] in da850.c > needs to be fixed to add the matching device name. This clock can be used for usb 1.1 PHY even when musb is not being used, so I don't think we can depend on having a musb device here. Also, in a previous review, it was decided that the usb clocks should *not* be added to da850_clks[] [1]. Instead, they are dynamically registered elsewhere. [1]: http://www.gossamer-threads.com/lists/linux/kernel/2396533 > >> + if (IS_ERR(usb20_clk)) { >> + pr_err("could not get usb20 clk\n"); >> + return; >> + } > > Thanks, > Sekhar >