Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965965AbcJYQm6 (ORCPT ); Tue, 25 Oct 2016 12:42:58 -0400 Received: from mail.kernel.org ([198.145.29.136]:41382 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941961AbcJYQmg (ORCPT ); Tue, 25 Oct 2016 12:42:36 -0400 From: Kieran Bingham To: Wolfram Sang , Lee Jones , Kieran Bingham Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas , sameo@linux.intel.com Subject: [PATCHv6 08/11] i2c: match vendorless strings on the internal string length Date: Tue, 25 Oct 2016 17:41:52 +0100 Message-Id: <1477413715-22894-9-git-send-email-kieran@bingham.xyz> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1477413715-22894-1-git-send-email-kieran@bingham.xyz> References: <1477413715-22894-1-git-send-email-kieran@bingham.xyz> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 29 If a user provides a shortened string to match a device to the sysfs i2c interface it will match on the first string that contains that string prefix. for example: echo a 0x68 > /sys/bus/i2c/devices/i2c-2/new_device will match as3711, as3722, and ak8975 incorrectly. Signed-off-by: Kieran Bingham --- drivers/i2c/i2c-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index 01bce56f733a..50c9cfdb87b7 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c @@ -1708,7 +1708,7 @@ i2c_of_match_device_strip_vendor(const struct of_device_id *matches, else name++; - if (!strncasecmp(client->name, name, strlen(client->name))) + if (!strncasecmp(client->name, name, strlen(name))) return matches; } -- 2.7.4