Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759501AbcJYRTA (ORCPT ); Tue, 25 Oct 2016 13:19:00 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.160]:17994 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754458AbcJYRS6 (ORCPT ); Tue, 25 Oct 2016 13:18:58 -0400 X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcZa0CjPwrtwsa7s0mYZj78qgNzGDY9gqCq X-RZG-CLASS-ID: mo00 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset jack detection From: "H. Nikolaus Schaller" In-Reply-To: <105a8b87-69d0-19c7-8337-7d32fd6e997a@ti.com> Date: Tue, 25 Oct 2016 19:18:46 +0200 Cc: =?utf-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Russell King , devicetree@vger.kernel.org, letux-kernel@openphoenux.org, linux-kernel@vger.kernel.org, ldewangan@nvidia.com, kernel@pyra-handheld.com, marek@goldelico.com, linux-omap@vger.kernel.org Message-Id: <7F106936-5748-432F-B602-59B890D5396A@goldelico.com> References: <7771a9fb3b9133fc361c87970444c1a3918891d0.1477414105.git.hns@goldelico.com> <105a8b87-69d0-19c7-8337-7d32fd6e997a@ti.com> To: Peter Ujfalusi X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9PHJHn8023883 Content-Length: 1095 Lines: 40 > Am 25.10.2016 um 18:51 schrieb Peter Ujfalusi : > > On 10/25/2016 07:48 PM, H. Nikolaus Schaller wrote: >> Signed-off-by: H. Nikolaus Schaller >> --- >> arch/arm/boot/dts/omap5-board-common.dtsi | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi >> index b04adee..91456b4 100644 >> --- a/arch/arm/boot/dts/omap5-board-common.dtsi >> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi >> @@ -124,6 +124,7 @@ >> compatible = "ti,abe-twl6040"; >> ti,model = "omap5-uevm"; >> >> + ti,jack_detection; > > ti,jack-detection Hm. Looks as if we have found another bug: which one is correct? https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt#n15 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/soc/omap/omap-abe-twl6040.c#n289 Should I add another patch? > >> ti,mclk-freq = <19200000>; >> >> ti,mcpdm = <&mcpdm>; >> > > > -- > Péter