Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S941961AbcJYReS (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Oct 2016 13:34:18 -0400
Received: from muru.com ([72.249.23.125]:45908 "EHLO muru.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933239AbcJYReR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Oct 2016 13:34:17 -0400
Date: Tue, 25 Oct 2016 10:34:11 -0700
From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
        =?utf-8?Q?Beno=C3=AEt?= Cousson <bcousson@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>,
        Russell King <linux@armlinux.org.uk>, devicetree@vger.kernel.org,
        letux-kernel@openphoenux.org, linux-kernel@vger.kernel.org,
        ldewangan@nvidia.com, kernel@pyra-handheld.com, marek@goldelico.com,
        linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset
 jack detection
Message-ID: <20161025173411.36uop63p2wzv3gij@atomide.com>
References: <cover.1477414105.git.hns@goldelico.com>
 <7771a9fb3b9133fc361c87970444c1a3918891d0.1477414105.git.hns@goldelico.com>
 <105a8b87-69d0-19c7-8337-7d32fd6e997a@ti.com>
 <7F106936-5748-432F-B602-59B890D5396A@goldelico.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7F106936-5748-432F-B602-59B890D5396A@goldelico.com>
User-Agent: Mutt/1.6.2-neo (2016-07-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1301
Lines: 38

* H. Nikolaus Schaller <hns@goldelico.com> [161025 10:20]:
> 
> > Am 25.10.2016 um 18:51 schrieb Peter Ujfalusi <peter.ujfalusi@ti.com>:
> > 
> > On 10/25/2016 07:48 PM, H. Nikolaus Schaller wrote:
> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> >> ---
> >> arch/arm/boot/dts/omap5-board-common.dtsi | 1 +
> >> 1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
> >> index b04adee..91456b4 100644
> >> --- a/arch/arm/boot/dts/omap5-board-common.dtsi
> >> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi
> >> @@ -124,6 +124,7 @@
> >> 		compatible = "ti,abe-twl6040";
> >> 		ti,model = "omap5-uevm";
> >> 
> >> +		ti,jack_detection;
> > 
> > ti,jack-detection
> 
> Hm. Looks as if we have found another bug:
> which one is correct?
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt#n15
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/soc/omap/omap-abe-twl6040.c#n289
> 
> Should I add another patch?

We have parts of omap-abe-twl6040.txt, the driver and omap4-sdp.dts all
using ti,jack-detection. So omap-abe-twl6040.txt is wrong for the use
of ti,jack_detection.

Regards,

Tony