Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965428AbcJYSH4 (ORCPT ); Tue, 25 Oct 2016 14:07:56 -0400 Received: from mail.kernel.org ([198.145.29.136]:56136 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932529AbcJYSHw (ORCPT ); Tue, 25 Oct 2016 14:07:52 -0400 Date: Tue, 25 Oct 2016 15:07:46 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an activity Message-ID: <20161025180746.GF4543@kernel.org> References: <20161024020246.14928-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161024020246.14928-1-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 956 Lines: 30 Em Mon, Oct 24, 2016 at 11:02:43AM +0900, Namhyung Kim escreveu: > Applying cpu color always doesn't help readability IMHO. Instead it > might be better to applying the color when there's an activity on those > CPUs. thanks, applied the three patches. - Arnaldo > Cc: Jiri Olsa > Signed-off-by: Namhyung Kim > --- > tools/perf/builtin-sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c > index f5503ca22e1c..78006e991d91 100644 > --- a/tools/perf/builtin-sched.c > +++ b/tools/perf/builtin-sched.c > @@ -1479,7 +1479,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel, > cpu_color = COLOR_CPUS; > > if (cpu != this_cpu) > - color_fprintf(stdout, cpu_color, " "); > + color_fprintf(stdout, color, " "); > else > color_fprintf(stdout, cpu_color, "*"); > > -- > 2.10.0