Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758763AbcJYSLN (ORCPT ); Tue, 25 Oct 2016 14:11:13 -0400 Received: from mail.kernel.org ([198.145.29.136]:56816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753060AbcJYSLL (ORCPT ); Tue, 25 Oct 2016 14:11:11 -0400 Date: Tue, 25 Oct 2016 15:11:05 -0300 From: Arnaldo Carvalho de Melo To: "Jin, Yao" Cc: Andi Kleen , Nilay Vaish , Jiri Olsa , Linux Kernel list , kan.liang@intel.com Subject: Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain Message-ID: <20161025181105.GH4543@kernel.org> References: <1476914477-25420-1-git-send-email-yao.jin@linux.intel.com> <1476914477-25420-3-git-send-email-yao.jin@linux.intel.com> <20161020164854.GB1075@tassilo.jf.intel.com> <20161020182036.GC1075@tassilo.jf.intel.com> <747ba5dc-8015-7634-eb1c-94f82ebb75b1@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <747ba5dc-8015-7634-eb1c-94f82ebb75b1@linux.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1154 Lines: 35 Em Fri, Oct 21, 2016 at 08:23:41AM +0800, Jin, Yao escreveu: > Hi Andi, Hi Nilay, > > Thanks so much for your comments! > > I will upgrade the patch to just display the count for abort. Ok, waiting for that then, - Arnaldo > Thanks > > Jin Yao > > On 10/21/2016 2:20 AM, Andi Kleen wrote: > > > OK, I am more confused now. Are you predicting some quantity related > > > to transactions? Why would you divide abort count by branch count? > > > Further, I just looked at patch 6/6. It has the following text: > > > > > > + Also show with some branch flags that can be: > > > + - Predicted: display the average percentage of predicated branches. > > > + (predicated number / total number) > > > + - Abort: display the average percentage of abort branches. > > > + (abort number /total number) > > > + - Cycles: cycles in basic block. > > > > > > > > > I think there is inconsistency between what you are suggesting and > > > what the patch has. > > An abort is an unique branch. But yes there is no total number, > > so the formula will always be 100%. So yes would probably be > > better to just display a count for abort. > > > > -Andi