Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934809AbcJYSYI (ORCPT ); Tue, 25 Oct 2016 14:24:08 -0400 Received: from mail-qt0-f176.google.com ([209.85.216.176]:35926 "EHLO mail-qt0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753299AbcJYSYF (ORCPT ); Tue, 25 Oct 2016 14:24:05 -0400 MIME-Version: 1.0 In-Reply-To: <1477413083-9159-1-git-send-email-tthayer@opensource.altera.com> References: <1477413083-9159-1-git-send-email-tthayer@opensource.altera.com> From: Linus Walleij Date: Tue, 25 Oct 2016 20:24:04 +0200 Message-ID: Subject: Re: [PATCH] gpio: gpiolib-devprop: Check chip->parent pointer before dereferencing To: Thor Thayer Cc: Alexandre Courbot , Mika Westerberg , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 378 Lines: 15 On Tue, Oct 25, 2016 at 6:31 PM, wrote: > From: Thor Thayer > > Confirm the chip->parent is valid before dereferencing because > the parent parameter is optional. > > Signed-off-by: Thor Thayer I wish it wasn't. Not much to do about though. Patch applied. Yours, Linus Walleij