Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759479AbcJYSrs (ORCPT ); Tue, 25 Oct 2016 14:47:48 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36570 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752881AbcJYSrq (ORCPT ); Tue, 25 Oct 2016 14:47:46 -0400 MIME-Version: 1.0 In-Reply-To: <20161024201443.GB5989@amd> References: <1475092512-30555-1-git-send-email-matt@ranostay.consulting> <1475092512-30555-3-git-send-email-matt@ranostay.consulting> <20161024201443.GB5989@amd> From: Matt Ranostay Date: Tue, 25 Oct 2016 11:47:03 -0700 Message-ID: Subject: Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query To: Pavel Machek Cc: pali.rohar@gmail.com, Sebastian Reichel , kernel list , linux-arm-kernel , Linux OMAP List , Tony Lindgren , khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 895 Lines: 25 On Mon, Oct 24, 2016 at 1:14 PM, Pavel Machek wrote: > On Mon 2016-10-24 12:58:25, Matt Ranostay wrote: >> Pavel + Sebastian this is the patchset that need I some input on :) > > Better then previous one. > > But my version of bq27xxx_battery.c already contains this: This is for allowing udev rule to set the properties as well. otherwise a kinda crude RUN = " echo value > /sys/module/bq27xxx_battery/parameters/poll_interval" is required. > > static const struct kernel_param_ops param_ops_poll_interval = { > .get = param_get_uint, > .set = poll_interval_param_set, > }; > > ...so it should be possible to set poll interval already. > > Pavel > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html