Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754170AbcJYT3z (ORCPT ); Tue, 25 Oct 2016 15:29:55 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:39875 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935080AbcJYT3v (ORCPT ); Tue, 25 Oct 2016 15:29:51 -0400 X-Auth-Info: crEj8eljHHLBIx3sKndNAlcZgz6dGy1FhHnHFX1HdJI= Subject: Re: [PATCH v3 1/9] mtd: spi-nor: improve macronix_quad_enable() To: Cyrille Pitchen , computersforpeace@gmail.com, linux-mtd@lists.infradead.org References: <74f0fa1b-3212-8a21-f966-14f153d2bf43@denx.de> <6948ab96-62ab-c383-4f50-e897be0999b3@atmel.com> Cc: nicolas.ferre@atmel.com, boris.brezillon@free-electrons.com, richard@nod.at, linux-kernel@vger.kernel.org From: Marek Vasut Message-ID: <32ea0535-97a6-34d6-7263-24f155d3da62@denx.de> Date: Tue, 25 Oct 2016 16:49:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <6948ab96-62ab-c383-4f50-e897be0999b3@atmel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1660 Lines: 44 On 10/25/2016 10:52 AM, Cyrille Pitchen wrote: > Hi Marek, > > Le 25/10/2016 à 00:00, Marek Vasut a écrit : >> On 10/24/2016 06:34 PM, Cyrille Pitchen wrote: >>> The patch checks whether the Quad Enable bit is already set in the Status >>> Register. If so, the function exits immediately with a successful return >>> code. Otherwise, a message is now printed telling we're setting the >>> non-volatile bit. >>> >>> Signed-off-by: Cyrille Pitchen >>> Reviewed-by: Jagan Teki >>> --- >>> drivers/mtd/spi-nor/spi-nor.c | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c >>> index d0fc165d7d66..5c87b2d99507 100644 >>> --- a/drivers/mtd/spi-nor/spi-nor.c >>> +++ b/drivers/mtd/spi-nor/spi-nor.c >>> @@ -1211,6 +1211,11 @@ static int macronix_quad_enable(struct spi_nor *nor) >>> val = read_sr(nor); >>> if (val < 0) >>> return val; >>> + if (val & SR_QUAD_EN_MX) >>> + return 0; >>> + >>> + /* Update the Quad Enable bit. */ >>> + dev_info(nor->dev, "setting Macronix Quad Enable (non-volatile) bit\n"); >> >> Should probably be dev_dbg(), since this is just churn in the kernel >> log. The user doesn't care and the developer can just up the debug level >> or add his own printk . >> > > The Quad Enable bit is non-volatile so this trace should be printed only once > but I'm perfectly fine with using dev_dbg(). I'll change it in the next version. I get it, but what's the value of it ? Who will make use of this information being in the kernel log? The kernel is already chatty enough :) -- Best regards, Marek Vasut