From: "Deucher, Alexander" <Alexander.Deucher@amd.com>
To: "'Arnd Bergmann'" <arnd@arndb.de>, Baoyou Xie <baoyou.xie@linaro.org>
CC: Dave Airlie <airlied@linux.ie>, "Zhu, Rex" <Rex.Zhu@amd.com>,
        "Zhou, Jammy" <Jammy.Zhou@amd.com>,
        "Huang, JinHuiEric" <JinHuiEric.Huang@amd.com>,
        "StDenis, Tom" <Tom.StDenis@amd.com>,
        "Edward O'Callaghan" <funfunctor@folklore1984.net>,
        "Prosyak, Vitaly" <Vitaly.Prosyak@amd.com>,
        "Yang, Eric" <Eric.Yang2@amd.com>, "Yang, Young" <Young.Yang@amd.com>,
        "Huang, Ray" <Ray.Huang@amd.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        "Cui, Flora" <Flora.Cui@amd.com>,
        =?iso-8859-1?Q?Nils_Wallm=E9nius?= <nils.wallmenius@gmail.com>,
        "Liu, Monk" <Monk.Liu@amd.com>, "Wang, Ken" <Ken.Wang@amd.com>,
        "Min, Frank" <Frank.Min@amd.com>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "xie.baoyou@zte.com.cn" <xie.baoyou@zte.com.cn>,
        "han.fei@zte.com.cn" <han.fei@zte.com.cn>,
        "tang.qiang007@zte.com.cn" <tang.qiang007@zte.com.cn>
Subject: RE: [PATCH] drm/amd/powerplay: mark symbols static where possible
Thread-Topic: [PATCH] drm/amd/powerplay: mark symbols static where possible
Thread-Index: AQHSLEJIm92MnInRcEaIoVpfU6VMC6C4GCqAgABfEICAAGAKAIAAZ28A
Date: Tue, 25 Oct 2016 20:07:29 +0000
Message-ID: <MWHPR12MB1694F9ADB8D49C90439A4914F7A80@MWHPR12MB1694.namprd12.prod.outlook.com>
References: <1477126582-2906-1-git-send-email-baoyou.xie@linaro.org>
 <6582910.6C6abby7Jc@wuerfel>
 <CA+DQWkxdO72H4ZbUkYyJwPOe2JGRv_Tz1eUkZ5=FJoOonoWp=Q@mail.gmail.com>
 <10254575.qBa8RMPyZ5@wuerfel>
In-Reply-To: <10254575.qBa8RMPyZ5@wuerfel>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2016 20:07:29.0356
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1344
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9PK7chh024798
Content-Length: 1915
Lines: 45

> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Tuesday, October 25, 2016 4:15 AM
> To: Baoyou Xie
> Cc: Deucher, Alexander; Dave Airlie; Zhu, Rex; Zhou, Jammy; Huang,
> JinHuiEric; StDenis, Tom; Edward O'Callaghan; Prosyak, Vitaly; Yang, Eric;
> Yang, Young; Huang, Ray; Dan Carpenter; Cui, Flora; Nils Wallm?nius; Liu,
> Monk; Wang, Ken; Min, Frank; dri-devel; Linux Kernel Mailing List;
> xie.baoyou@zte.com.cn; han.fei@zte.com.cn; tang.qiang007@zte.com.cn
> Subject: Re: [PATCH] drm/amd/powerplay: mark symbols static where
> possible
> 
> On Tuesday, October 25, 2016 10:31:21 AM CEST Baoyou Xie wrote:
> > On 25 October 2016 at 04:51, Arnd Bergmann <arnd@arndb.de> wrote:
> > > On Saturday, October 22, 2016 4:56:22 PM CEST Baoyou Xie wrote:
> > > The function has no callers, so the easiest way would be to remove it
> > > entirely, but it's possible that there are plans to add users soon.
> > >
> > > It was assumed that this function will be used soon, so this patch remains
> > it.
> > if it still not be used in 4.10, then we can remove it.
> > is it right?
> 
> There is no such rule in general, it's up to the maintainer and
> it depends on the specific reason for why the function ended up
> being unused in the first place.
> 
> However, we can expect the maintainer to come up with some solution
> to address the warning. Possible options include:
> 
> - calling the function from where it was meant to be used
> - removing the function
> - adding __maybe_unused
> - adding an #if 0
> 
> I have not looked at this specific example and do not know
> which of them would be appropriate here. If you look at the
> output of 'git log -p
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c'
> you might find it out yourself.

This is mostly fallout from a big cleanup/re-org of the powerplay code in the 4.9.  Rex said he was going to use these soon.  

Alex