From: Arnd Bergmann <arnd@arndb.de>
To: Sriram Dash <sriram.dash@nxp.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        mathias.nyman@intel.com, gregkh@linuxfoundation.org,
        suresh.gupta@nxp.com, felipe.balbi@linux.intel.com,
        stern@rowland.harvard.edu, pku.leo@gmail.com
Subject: Re: [PATCH 3/3] usb: dwc3: host: Do not use dma_coerce_mask_and_coherent
Date: Tue, 25 Oct 2016 22:27:37 +0200
Message-ID: <4598901.ugkIQYLvkL@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1477392988-7253-4-git-send-email-sriram.dash@nxp.com>
References: <1477392988-7253-1-git-send-email-sriram.dash@nxp.com> <1477392988-7253-4-git-send-email-sriram.dash@nxp.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 753
Lines: 22

On Tuesday, October 25, 2016 4:26:28 PM CEST Sriram Dash wrote:
> Do not use dma_coerce_mask_and_coherent for hcd.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

The patch is good, but please follow the usual rules for submitting
someone else's patch:

- As the first line, have "From: Arnd Bergmann <arnd@arndb.de>".
  "git format-patch" adds this automatically if you pass that
  address as the "--author" argument to "git commit".

- Add you "Signed-off-by" line at below mine (or any other lines)

I would also suggest a more elaborate changelog text, the
free-form text should explain why something is done, rather than
repeat the subject:

| The dma mask is correctly set up by the DT probe function, no
| need to override it any more.

	Arnd