Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758685AbcJYUb6 (ORCPT ); Tue, 25 Oct 2016 16:31:58 -0400 Received: from mga14.intel.com ([192.55.52.115]:17096 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753153AbcJYUb4 (ORCPT ); Tue, 25 Oct 2016 16:31:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,399,1473145200"; d="scan'208";a="23603574" Date: Tue, 25 Oct 2016 23:31:52 +0300 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: "Winkler, Tomas" , "tpmdd-devel@lists.sourceforge.net" , open list Subject: Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag Message-ID: <20161025203152.o4p3gmxeare6idpz@intel.com> References: <20161017204224.27163-1-jarkko.sakkinen@linux.intel.com> <20161017225113.qnghq5vroxlmsurc@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B542FF8FC@hasmsx108.ger.corp.intel.com> <20161019160928.n5fswy25t2ppdh73@intel.com> <20161020135906.ah4rjympz3wq6g3t@intel.com> <20161020140011.s5mu3atjjwnwqda4@intel.com> <20161020202421.GA13459@obsidianresearch.com> <20161021151141.oyxtjkfgn26nznty@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161021151141.oyxtjkfgn26nznty@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 20 On Fri, Oct 21, 2016 at 06:11:41PM +0300, Jarkko Sakkinen wrote: > On Thu, Oct 20, 2016 at 02:24:21PM -0600, Jason Gunthorpe wrote: > > On Thu, Oct 20, 2016 at 05:00:11PM +0300, Jarkko Sakkinen wrote: > > > > > > > I have a 4th Gen Core NUC where I experienced this issue. It reported > > > > > requiring only ACPI start but actually required ACPI + CRB start. The > > > > > comment could have been better. > > > > Shouldn't bios work arounds be keyed on something? What happens if a > > system rolls around that cannot do ACPI + CRB start? How does this > > system work in windows? > > I didn't find anything better to key it on at the time and it has been > working for two years now without any problems. I've though about this and came to conclusion that maybe I won't apply this patch because it is good to keep this robustness in for now. I think your point is valid. /Jarkko