Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755138AbcJYUrQ (ORCPT ); Tue, 25 Oct 2016 16:47:16 -0400 Received: from smtprelay2.synopsys.com ([198.182.60.111]:48113 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752277AbcJYUrP (ORCPT ); Tue, 25 Oct 2016 16:47:15 -0400 Subject: Re: [PATCH] phy: Add reset callback for not generic phy To: Randy Li , "linux-usb@vger.kernel.org" References: <1477404934-7425-1-git-send-email-ayaka@soulik.info> CC: "John.Youn@synopsys.com" , "kishon@ti.com" , "felipe.balbi@linux.intel.com" , "mark.rutland@arm.com" , "linux-rockchip@lists.infradead.org" , "randy.li@rock-chips.com" , "linux-kernel@vger.kernel.org" From: John Youn Message-ID: <8c8d86e6-a3b1-a381-dd3f-70e43768cfb9@synopsys.com> Date: Tue, 25 Oct 2016 13:47:03 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1477404934-7425-1-git-send-email-ayaka@soulik.info> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.9.139.37] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 886 Lines: 44 On 10/25/2016 7:15 AM, Randy Li wrote: > I forget to add a dummy function in case the CONFIG_GENERIC_PHY > is disabled. > > Signed-off-by: Randy Li Fixes: cac18ecb6f44 ("phy: Add reset callback") Tested-by: John Youn Hi Kishon, Can you take this for 4.9-rc? Thanks, John > --- > include/linux/phy/phy.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index ee1bed7..78bb0d7 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -253,6 +253,13 @@ static inline int phy_set_mode(struct phy *phy, enum phy_mode mode) > return -ENOSYS; > } > > +static inline int phy_reset(struct phy *phy) > +{ > + if (!phy) > + return 0; > + return -ENOSYS; > +} > + > static inline int phy_get_bus_width(struct phy *phy) > { > return -ENOSYS; > >