Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966056AbcJYVA2 (ORCPT ); Tue, 25 Oct 2016 17:00:28 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36206 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759589AbcJYVAO (ORCPT ); Tue, 25 Oct 2016 17:00:14 -0400 From: frowand.list@gmail.com To: Rob Herring , pantelis.antoniou@konsulko.com, Pantelis Antoniou Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 13/13] of: Remove unused variable overlay_symbols Date: Tue, 25 Oct 2016 13:59:06 -0700 Message-Id: <1477429146-27039-14-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1477429146-27039-1-git-send-email-frowand.list@gmail.com> References: <1477429146-27039-1-git-send-email-frowand.list@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1311 Lines: 39 From: Frank Rowand This unused variable is a reminder that symbols in overlays are not available to subsequent overlays. If such a feature is desired then there are several ways it could be implemented. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 3f7cf569c7ea..b48d16200ccd 100644 --- a/drivers/of/resolver.c +++ b/drivers/of/resolver.c @@ -272,7 +272,7 @@ static int adjust_local_phandle_references(struct device_node *local_fixups, int of_resolve_phandles(struct device_node *overlay) { struct device_node *child, *local_fixups, *refnode; - struct device_node *tree_symbols, *overlay_symbols, *overlay_fixups; + struct device_node *tree_symbols, *overlay_fixups; struct property *prop; const char *refpath; phandle phandle, phandle_delta; @@ -302,12 +302,9 @@ int of_resolve_phandles(struct device_node *overlay) if (err) goto err_out; - overlay_symbols = NULL; overlay_fixups = NULL; for_each_child_of_node(overlay, child) { - if (!of_node_cmp(child->name, "__symbols__")) - overlay_symbols = child; if (!of_node_cmp(child->name, "__fixups__")) overlay_fixups = child; } -- 1.9.1