Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942042AbcJYVZ2 (ORCPT ); Tue, 25 Oct 2016 17:25:28 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36206 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932297AbcJYVZ1 (ORCPT ); Tue, 25 Oct 2016 17:25:27 -0400 Date: Wed, 26 Oct 2016 06:24:41 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an activity Message-ID: <20161025212441.GA24538@danjae.aot.lge.com> References: <20161024020246.14928-1-namhyung@kernel.org> <20161025180746.GF4543@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161025180746.GF4543@kernel.org> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1112 Lines: 30 Hi Arnaldo, On Tue, Oct 25, 2016 at 03:07:46PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 24, 2016 at 11:02:43AM +0900, Namhyung Kim escreveu: > > Applying cpu color always doesn't help readability IMHO. Instead it > > might be better to applying the color when there's an activity on those > > CPUs. > > thanks, applied the three patches. Thanks, but unfortunately the patch 3/3 has a bug. Could you please fold the fix below into the patch? Thanks, Namhyung diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c index f0ab715b4923..a8e58d495a66 100644 --- a/tools/perf/builtin-sched.c +++ b/tools/perf/builtin-sched.c @@ -1218,7 +1218,7 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_ (double)work_list->total_runtime / NSEC_PER_MSEC, work_list->nb_atoms, (double)avg / NSEC_PER_MSEC, (double)work_list->max_lat / NSEC_PER_MSEC, - timestamp_in_usec(buf, sizeof(buf), work_list->max_lat)); + timestamp_in_usec(buf, sizeof(buf), work_list->max_lat_at)); } static int pid_cmp(struct work_atoms *l, struct work_atoms *r)