Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753790AbcJZGuM (ORCPT ); Wed, 26 Oct 2016 02:50:12 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38418 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753251AbcJZGuK (ORCPT ); Wed, 26 Oct 2016 02:50:10 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 78B8061406 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arnd Bergmann Cc: Arend van Spriel , Linus Torvalds , linux-kernel@vger.kernel.org, Hante Meuleman , Franky Lin , Pieter-Paul Giesberts , "Franky \(Zhenhui\) Lin" , =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org Subject: Re: [PATCH 19/28] brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap References: <20161017220342.1627073-1-arnd@arndb.de> <20161017221355.1861551-7-arnd@arndb.de> Date: Wed, 26 Oct 2016 09:49:58 +0300 In-Reply-To: <20161017221355.1861551-7-arnd@arndb.de> (Arnd Bergmann's message of "Tue, 18 Oct 2016 00:13:40 +0200") Message-ID: <87zilr61ux.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9Q6oJki027323 Content-Length: 1042 Lines: 25 Arnd Bergmann writes: > A bugfix added a sanity check around the assignment and use of the > 'is_11d' variable, which looks correct to me, but as the function is > rather complex already, this confuses the compiler to the point where > it can no longer figure out if the variable is always initialized > correctly: > > brcm80211/brcmfmac/cfg80211.c: In function ‘brcmf_cfg80211_start_ap’: > brcm80211/brcmfmac/cfg80211.c:4586:10: error: ‘is_11d’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This adds an initialization for the newly introduced case in which > the variable should not really be used, in order to make the warning > go away. > > Fixes: b3589dfe0212 ("brcmfmac: ignore 11d configuration errors") > Cc: Hante Meuleman > Cc: Arend van Spriel > Cc: Kalle Valo > Signed-off-by: Arnd Bergmann Via which tree are you planning to submit this? Should I take it? -- Kalle Valo