Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753872AbcJZG5c convert rfc822-to-8bit (ORCPT ); Wed, 26 Oct 2016 02:57:32 -0400 Received: from mga07.intel.com ([134.134.136.100]:34613 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751792AbcJZG5a (ORCPT ); Wed, 26 Oct 2016 02:57:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,549,1473145200"; d="scan'208";a="1059265979" From: "Tian, Kevin" To: Kirti Wankhede , "alex.williamson@redhat.com" , "pbonzini@redhat.com" , "kraxel@redhat.com" , "cjia@nvidia.com" CC: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "Song, Jike" , "bjsdjshi@linux.vnet.ibm.com" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v9 02/12] vfio: VFIO based driver for Mediated devices Thread-Topic: [PATCH v9 02/12] vfio: VFIO based driver for Mediated devices Thread-Index: AQHSKLxnZWmUFMpbnU2SXCQOWNy/76C6WcmQ Date: Wed, 26 Oct 2016 06:57:26 +0000 Message-ID: References: <1476739332-4911-1-git-send-email-kwankhede@nvidia.com> <1476739332-4911-3-git-send-email-kwankhede@nvidia.com> In-Reply-To: <1476739332-4911-3-git-send-email-kwankhede@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzM4MTVmYjMtOTc4Yi00YzdlLTgzNTUtMWU1MjZhMjkxNzRiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlBYVzlXa3BLUmR2XC90anFnaXZHTUZtRlk2cTF3c0NSTThpSHVBZjNleGFrPSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5933 Lines: 208 > From: Kirti Wankhede [mailto:kwankhede@nvidia.com] > Sent: Tuesday, October 18, 2016 5:22 AM > > vfio_mdev driver registers with mdev core driver. > MDEV core driver creates mediated device and calls probe routine of use same case - either 'mdev core' or 'MDEV core' > vfio_mdev driver for each device. > Probe routine of vfio_mdev driver adds mediated device to VFIO core module > > This driver forms a shim layer that pass through VFIO devices operations > to vendor driver for mediated devices. > > Signed-off-by: Kirti Wankhede > Signed-off-by: Neo Jia > Change-Id: I583f4734752971d3d112324d69e2508c88f359ec > --- > drivers/vfio/mdev/Kconfig | 7 ++ > drivers/vfio/mdev/Makefile | 1 + > drivers/vfio/mdev/vfio_mdev.c | 148 > ++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 156 insertions(+) > create mode 100644 drivers/vfio/mdev/vfio_mdev.c > > diff --git a/drivers/vfio/mdev/Kconfig b/drivers/vfio/mdev/Kconfig > index 93addace9a67..6cef0c4d2ceb 100644 > --- a/drivers/vfio/mdev/Kconfig > +++ b/drivers/vfio/mdev/Kconfig > @@ -9,3 +9,10 @@ config VFIO_MDEV > See Documentation/vfio-mdev/vfio-mediated-device.txt for more details. > > If you don't know what do here, say N. > + > +config VFIO_MDEV_DEVICE > + tristate "VFIO support for Mediated devices" > + depends on VFIO && VFIO_MDEV > + default n > + help > + VFIO based driver for mediated devices. > diff --git a/drivers/vfio/mdev/Makefile b/drivers/vfio/mdev/Makefile > index 31bc04801d94..fa2d5ea466ee 100644 > --- a/drivers/vfio/mdev/Makefile > +++ b/drivers/vfio/mdev/Makefile > @@ -2,3 +2,4 @@ > mdev-y := mdev_core.o mdev_sysfs.o mdev_driver.o > > obj-$(CONFIG_VFIO_MDEV) += mdev.o > +obj-$(CONFIG_VFIO_MDEV_DEVICE) += vfio_mdev.o > diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c > new file mode 100644 > index 000000000000..b7b47604ce7a > --- /dev/null > +++ b/drivers/vfio/mdev/vfio_mdev.c > @@ -0,0 +1,148 @@ > +/* > + * VFIO based driver for Mediated device > + * > + * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved. > + * Author: Neo Jia > + * Kirti Wankhede > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "mdev_private.h" > + > +#define DRIVER_VERSION "0.1" > +#define DRIVER_AUTHOR "NVIDIA Corporation" > +#define DRIVER_DESC "VFIO based driver for Mediated device" > + > +static int vfio_mdev_open(void *device_data) > +{ > + struct mdev_device *mdev = device_data; > + struct parent_device *parent = mdev->parent; > + int ret; > + > + if (unlikely(!parent->ops->open)) > + return -EINVAL; > + > + if (!try_module_get(THIS_MODULE)) > + return -ENODEV; > + > + ret = parent->ops->open(mdev); > + if (ret) > + module_put(THIS_MODULE); > + > + return ret; > +} > + > +static void vfio_mdev_release(void *device_data) > +{ > + struct mdev_device *mdev = device_data; > + struct parent_device *parent = mdev->parent; > + > + if (parent->ops->release) likely() > + parent->ops->release(mdev); > + > + module_put(THIS_MODULE); > +} > + > +static long vfio_mdev_unlocked_ioctl(void *device_data, > + unsigned int cmd, unsigned long arg) > +{ > + struct mdev_device *mdev = device_data; > + struct parent_device *parent = mdev->parent; > + > + if (unlikely(!parent->ops->ioctl)) > + return -EINVAL; > + > + return parent->ops->ioctl(mdev, cmd, arg); > +} > + > +static ssize_t vfio_mdev_read(void *device_data, char __user *buf, > + size_t count, loff_t *ppos) > +{ > + struct mdev_device *mdev = device_data; > + struct parent_device *parent = mdev->parent; > + > + if (unlikely(!parent->ops->read)) > + return -EINVAL; > + > + return parent->ops->read(mdev, buf, count, ppos); > +} > + > +static ssize_t vfio_mdev_write(void *device_data, const char __user *buf, > + size_t count, loff_t *ppos) > +{ > + struct mdev_device *mdev = device_data; > + struct parent_device *parent = mdev->parent; > + > + if (unlikely(!parent->ops->write)) > + return -EINVAL; > + > + return parent->ops->write(mdev, buf, count, ppos); > +} > + > +static int vfio_mdev_mmap(void *device_data, struct vm_area_struct *vma) > +{ > + struct mdev_device *mdev = device_data; > + struct parent_device *parent = mdev->parent; > + > + if (unlikely(!parent->ops->mmap)) > + return -EINVAL; > + > + return parent->ops->mmap(mdev, vma); > +} > + > +static const struct vfio_device_ops vfio_mdev_dev_ops = { > + .name = "vfio-mdev", > + .open = vfio_mdev_open, > + .release = vfio_mdev_release, > + .ioctl = vfio_mdev_unlocked_ioctl, > + .read = vfio_mdev_read, > + .write = vfio_mdev_write, > + .mmap = vfio_mdev_mmap, > +}; > + > +int vfio_mdev_probe(struct device *dev) > +{ > + struct mdev_device *mdev = to_mdev_device(dev); > + > + return vfio_add_group_dev(dev, &vfio_mdev_dev_ops, mdev); > +} > + > +void vfio_mdev_remove(struct device *dev) > +{ > + vfio_del_group_dev(dev); > +} > + > +struct mdev_driver vfio_mdev_driver = { > + .name = "vfio_mdev", > + .probe = vfio_mdev_probe, > + .remove = vfio_mdev_remove, > +}; > + > +static int __init vfio_mdev_init(void) > +{ > + return mdev_register_driver(&vfio_mdev_driver, THIS_MODULE); > +} > + > +static void __exit vfio_mdev_exit(void) > +{ > + mdev_unregister_driver(&vfio_mdev_driver); > +} > + > +module_init(vfio_mdev_init) > +module_exit(vfio_mdev_exit) > + > +MODULE_VERSION(DRIVER_VERSION); > +MODULE_LICENSE("GPL"); > +MODULE_AUTHOR(DRIVER_AUTHOR); > +MODULE_DESCRIPTION(DRIVER_DESC); > -- > 2.7.0