Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755612AbcJZIvc (ORCPT ); Wed, 26 Oct 2016 04:51:32 -0400 Received: from merlin.infradead.org ([205.233.59.134]:35936 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755301AbcJZIvQ (ORCPT ); Wed, 26 Oct 2016 04:51:16 -0400 Date: Wed, 26 Oct 2016 10:51:16 +0200 From: Peter Zijlstra To: Alexis Berlemont Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com Subject: Re: [PATCH 1/2] perf, x86-mm: Add exit-fault tracing Message-ID: <20161026085116.GZ3102@twins.programming.kicks-ass.net> References: <20161025235200.28781-1-alexis.berlemont@gmail.com> <20161025235200.28781-2-alexis.berlemont@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161025235200.28781-2-alexis.berlemont@gmail.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 26 On Wed, Oct 26, 2016 at 01:51:59AM +0200, Alexis Berlemont wrote: -ENOCHANGELOG > Signed-off-by: Alexis Berlemont > --- > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > index 9f72ca3..e31e8ef 100644 > --- a/arch/x86/mm/fault.c > +++ b/arch/x86/mm/fault.c > @@ -1488,6 +1488,7 @@ trace_do_page_fault(struct pt_regs *regs, unsigned long error_code) > prev_state = exception_enter(); > trace_page_fault_entries(address, regs, error_code); > __do_page_fault(regs, error_code, address); > + trace_page_fault_exit(address); Aside from my general hatred of tracepoint, it bugs me that its not symmetric like the irq vector ones. But I'll leave that to x86 people. > exception_exit(prev_state); > } > NOKPROBE_SYMBOL(trace_do_page_fault); > -- > 2.10.1 >