Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756029AbcJZI43 (ORCPT ); Wed, 26 Oct 2016 04:56:29 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:35588 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754283AbcJZI4Y (ORCPT ); Wed, 26 Oct 2016 04:56:24 -0400 Date: Wed, 26 Oct 2016 09:56:20 +0100 From: Peter Griffin To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, patrice.chotard@st.com, devicetree@vger.kernel.org Subject: Re: [PATCH] ARM: sti: stih410-clocks: Add PROC_STFE as a critical clock Message-ID: <20161026085620.GA5476@griffinp-ThinkPad-X1-Carbon-2nd> References: <1476804957-24000-1-git-send-email-peter.griffin@linaro.org> <20161024085304.GE14477@dell> <20161024134416.GB10440@griffinp-ThinkPad-X1-Carbon-2nd> <20161025074257.GF8574@dell> <20161025093926.GA3206@griffinp-ThinkPad-X1-Carbon-2nd> <20161025100141.GH8574@dell> <20161025134940.GA3993@griffinp-ThinkPad-X1-Carbon-2nd> <20161026085141.GJ8574@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161026085141.GJ8574@dell> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 795 Lines: 21 Hi Lee, On Wed, 26 Oct 2016, Lee Jones wrote: > > > > If the clock is enabled when Linux boots, the Linux clock framework *needs* > > > > to assume the hardware may have been used in previous boot stages, and it should > > > > not attempt to disable the clock. > > > > > > None of the boot loaders we use do this. > > > > But the Linux kernel isn't just used by us. It is not uncommon for STB > > bootloaders to get information from the frontend as part of the boot process. > > Okay, this is the clincher. Since we need to support non-standard > bootloaders, it's difficult to guarantee that the clock will be > disabled at boot. For this reason, I believe that we can call this a > critical clock. > That's good news as the STi maintainer already acked and applied the patch. Peter.