Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754824AbcJZJ5k convert rfc822-to-8bit (ORCPT ); Wed, 26 Oct 2016 05:57:40 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:59759 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752779AbcJZJ5h (ORCPT ); Wed, 26 Oct 2016 05:57:37 -0400 From: Arnd Bergmann To: Kalle Valo Cc: Arend van Spriel , Linus Torvalds , linux-kernel@vger.kernel.org, Hante Meuleman , Franky Lin , Pieter-Paul Giesberts , "Franky (Zhenhui) Lin" , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org Subject: Re: [PATCH 19/28] brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap Date: Wed, 26 Oct 2016 11:57:23 +0200 Message-ID: <3406231.8mt2808XDi@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <87zilr61ux.fsf@kamboji.qca.qualcomm.com> References: <20161017220342.1627073-1-arnd@arndb.de> <20161017221355.1861551-7-arnd@arndb.de> <87zilr61ux.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K0:fxKtPM4g1zC0+fYJWncNwsE5leoD1EPy0U42BArNUGPj90QVpgX gOze4qk3J9556lKqlKl1KB0hUYNnagEfhXLAi8zvfS2G/zfCSP4D+/Io4hSXSq+2aE1+0+q gIWBVDj0EpjsaxPXx2Bte2c5VEm96floz9hf73hLG7PHHfgSZgfcTchozQMOfVmkcj1uYmW xwSFTTMJYxeZUEzEsqyQw== X-UI-Out-Filterresults: notjunk:1;V01:K0:lB4jcJs9v2k=:Pu326UwWeLq2OMKIaRFT4X h235wDB98VHBDE82OG063SsR4q6revMq/eYi1uUlSJTmhrE1Zh9BwooznOZV5Ts9KqFSF+9oj BtoJIkQH6Fd/sJ3OOvduN3InLiZgBBaMD9YZLNO6O4ace6cRHA+blzIKjbMGazzr7vCfMdRFK jXOfZy+clf25ahrEQdeLQJDP0OgGXhbmsjd+MlSWZDZUqc0VairicoXkk/Iw5FYp3XtXOg7Bj 3WHStkcWiw9s7J6f6OgIxWwxyLCsKpx1+HmE1P2aUarsz8Ml+JO+HtY+tsZcbkX/LaTlQcKQA 213/ZGBq8uYMMWjrTh5OZxX9JrtOsQfZfM9X53P6d2wpvO3UW/5nK5MxNM7lUH6XjWo0CkgDa jSgyuF2j/nv7WxZHAOdZ5SDh1I3MPa9bMYR1vNWA3TglLWLp7+vmfyRjZom3K47y1Wuht1hMn 0ZNAJnZUv44SU8Rly2nX/485XgTh4XAeeMCBbX/YB1IDDZXKWDE9NGcP+Gi3nZfip0oe+42Rb zey/FRZnl9mXa+2ih3ZDXEQXU7tLnpA1UWqYll1YVl1kysyz+u90CW6aIcdwyAD170zss3WdJ vOfUvKuJCcfDIZXVxDhWXpFsJKDcx4bRs6ZNTW8btQstV1R0D81qrb0FKwoqegX4Iu1eDRj5y m2w7EQ6KDxAso5C75KS2nHM4+LtIyKLjSxLrDmz3Svedct2aMMAP/C/ZwkxoYpwqExEzHOxBq daOStJh4XLGUPJ7k Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1282 Lines: 29 On Wednesday, October 26, 2016 9:49:58 AM CEST Kalle Valo wrote: > Arnd Bergmann writes: > > > A bugfix added a sanity check around the assignment and use of the > > 'is_11d' variable, which looks correct to me, but as the function is > > rather complex already, this confuses the compiler to the point where > > it can no longer figure out if the variable is always initialized > > correctly: > > > > brcm80211/brcmfmac/cfg80211.c: In function ‘brcmf_cfg80211_start_ap’: > > brcm80211/brcmfmac/cfg80211.c:4586:10: error: ‘is_11d’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > > > > This adds an initialization for the newly introduced case in which > > the variable should not really be used, in order to make the warning > > go away. > > > > Fixes: b3589dfe0212 ("brcmfmac: ignore 11d configuration errors") > > Cc: Hante Meuleman > > Cc: Arend van Spriel > > Cc: Kalle Valo > > Signed-off-by: Arnd Bergmann > > Via which tree are you planning to submit this? Should I take it? I'd prefer if you can take it and forward it along with your other bugfixes. I'll try to take care of the ones that nobody else picked up. Arnd