Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932421AbcJZKeb (ORCPT ); Wed, 26 Oct 2016 06:34:31 -0400 Received: from foss.arm.com ([217.140.101.70]:36824 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932119AbcJZKe3 (ORCPT ); Wed, 26 Oct 2016 06:34:29 -0400 Date: Wed, 26 Oct 2016 11:33:55 +0100 From: Mark Rutland To: Minghuan Lian Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Marc Zyngier , Stuart Yoder , Yang-Leo Li , Scott Wood , Shawn Guo , Mingkai Hu Subject: Re: [PATCH 3/6] arm64: dts: ls1043a: update MSI and PCIe node Message-ID: <20161026103339.GD19965@leverpostej> References: <1477398945-22774-1-git-send-email-Minghuan.Lian@nxp.com> <1477398945-22774-3-git-send-email-Minghuan.Lian@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477398945-22774-3-git-send-email-Minghuan.Lian@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1128 Lines: 38 On Tue, Oct 25, 2016 at 08:35:42PM +0800, Minghuan Lian wrote: > 3. The rev1.1 of LS1043a moves PCIe INTB/C/D interrupts to MSI controller. [...] > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > index 41e5dc1..5295bb9 100644 > - interrupt-map = <0000 0 0 1 &gic 0 110 0x4>, > - <0000 0 0 2 &gic 0 111 0x4>, > - <0000 0 0 3 &gic 0 112 0x4>, > - <0000 0 0 4 &gic 0 113 0x4>; > + interrupt-map = <0000 0 0 1 &gic 0 110 0x4>; [...] > - interrupt-map = <0000 0 0 1 &gic 0 120 0x4>, > - <0000 0 0 2 &gic 0 121 0x4>, > - <0000 0 0 3 &gic 0 122 0x4>, > - <0000 0 0 4 &gic 0 123 0x4>; > + interrupt-map = <0000 0 0 1 &gic 0 120 0x4>; > }; [...] > - interrupt-map = <0000 0 0 1 &gic 0 154 0x4>, > - <0000 0 0 2 &gic 0 155 0x4>, > - <0000 0 0 3 &gic 0 156 0x4>, > - <0000 0 0 4 &gic 0 157 0x4>; > + interrupt-map = <0000 0 0 1 &gic 0 154 0x4>; Per the description above, this breaks revisions prior to 1.1. Please, split the rev 1.1 changes into a new DTS. Share the common parts in a common dtsi. Thanks, Mark.