Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754841AbcJZKnu (ORCPT ); Wed, 26 Oct 2016 06:43:50 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:38895 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752609AbcJZKnq (ORCPT ); Wed, 26 Oct 2016 06:43:46 -0400 MIME-Version: 1.0 In-Reply-To: <87y41bwfyy.fsf@concordia.ellerman.id.au> References: <20161005055726.5614-1-valentinrothberg@gmail.com> <1475708074.735.2.camel@gmail.com> <878ttby7vh.fsf@concordia.ellerman.id.au> <87y41bwfyy.fsf@concordia.ellerman.id.au> From: Valentin Rothberg Date: Wed, 26 Oct 2016 12:43:12 +0200 Message-ID: Subject: Re: [PATCH] powerpc: process.c: fix Kconfig typo To: Michael Ellerman Cc: Cyril Bur , LKML , "linuxppc-dev@lists.ozlabs.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1915 Lines: 55 On Wed, Oct 26, 2016 at 12:40 PM, Michael Ellerman wrote: > Valentin Rothberg writes: > >> On Wed, Oct 26, 2016 at 7:52 AM, Michael Ellerman wrote: >>> Cyril Bur writes: >>> >>>> On Wed, 2016-10-05 at 07:57 +0200, Valentin Rothberg wrote: >>>>> s/ALIVEC/ALTIVEC/ >>>>> >>>> >>>> Oops, nice catch >>>> >>>>> Signed-off-by: Valentin Rothberg >>>> >>>> Reviewed-by: Cyril Bur >>> >>> How did we not notice? Sounds like we need a new selftest. >>> >>> Looks like this should have: >>> >>> Fixes: dc16b553c949 ("powerpc: Always restore FPU/VEC/VSX if hardware transactional memory in use") >>> >>> >>> And I guess I need to start running checkkconfigsymbols.py on every >>> commit. >> >> Happy to find a new user :-) You can also run the script on a range >> of commits via '--diff commitA..commitB', which can safe some time. > > Yeah I just discovered that, very useful. > > But my instinct was to do: > > $ ./scripts/checkkconfigsymbols.py --diff HEAD^^^..HEAD > > Which didn't work, the regexp is a bit tight, fixed by: > > diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py > index a32e4da4c117..3820f00b066a 100755 > --- a/scripts/checkkconfigsymbols.py > +++ b/scripts/checkkconfigsymbols.py > @@ -88,7 +88,7 @@ def parse_options(): > if args.commit and args.diff: > sys.exit("Please specify only one option at once.") > > - if args.diff and not re.match(r"^[\w\-\.]+\.\.[\w\-\.]+$", args.diff): > + if args.diff and not re.match(r"^[\w\-\.\^]+\.\.[\w\-\.\^]+$", args.diff): > sys.exit("Please specify valid input in the following format: " > "\'commit1..commit2\'") Looks great. If you agree, I'll pick this up and send the patch to Greg (who takes patches for this script)? Thanks, Valentin