Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755187AbcJZKzo (ORCPT ); Wed, 26 Oct 2016 06:55:44 -0400 Received: from arroyo.ext.ti.com ([198.47.19.12]:52798 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753859AbcJZKzm (ORCPT ); Wed, 26 Oct 2016 06:55:42 -0400 Subject: Re: [PATCH 2/5] ARM: davinci: Don't append git rev to local version To: David Lechner , Kevin Hilman References: <1477075018-20176-1-git-send-email-david@lechnology.com> <1477075018-20176-3-git-send-email-david@lechnology.com> <20f3efba-4f79-3675-d2ce-09efe90fb692@ti.com> CC: Rob Herring , Mark Rutland , Russell King , , , From: Sekhar Nori Message-ID: <47ad8be9-54e0-4e0c-3ff5-31662e6ca4de@ti.com> Date: Wed, 26 Oct 2016 16:24:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1322 Lines: 37 On Monday 24 October 2016 08:45 PM, David Lechner wrote: > On 10/24/2016 06:35 AM, Sekhar Nori wrote: >> On Saturday 22 October 2016 12:06 AM, David Lechner wrote: >>> In the davinci default configuration, don't append the git revision to >>> the local kernel version by. This seems like the more desirable default >>> value. >> >> Why? To the contrary I actually quite like the fact that the git commit >> is appended to version string. Makes it easy for me to cross-check that >> I am booting the right image. >> >>> >>> Signed-off-by: David Lechner >> >> Thanks, >> Sekhar >> > > Each time you make a commit, you get a new version, which installs > another copy of the kernel modules on the device. This will fill up the > SD card if you are making many commits. Right, but thats easily fixable by removing existing modules before installing new ones. > Also, if someone wants to build the mainline kernel using the default > configuration, it seems odd to have a git revision tacked on to the end > even though you made no revisions. If you checkout a tag and build, then no commit information is added. Which I guess is what most end users will do. I don't see this done in other defconfigs like omap2plus and multi_v7 as well. I would like to keep it similar for davinci. Thanks, Sekhar