Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758849AbcJZLSD (ORCPT <rfc822;w@1wt.eu>);
        Wed, 26 Oct 2016 07:18:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46204 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1758146AbcJZLPt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Oct 2016 07:15:49 -0400
Subject: Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers
To: Wanpeng Li <kernellwp@gmail.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
References: <1477304593-3453-1-git-send-email-wanpeng.li@hotmail.com>
 <20161024150323.GB2247@potion>
 <fa03f516-25ea-40e7-dd47-4dc9753d1b5b@redhat.com>
 <20161024152737.GB3197@potion>
 <CANRm+CypjCjAJPzbd7SfHVB0940sMQx7Zz_0dbn=Dg-AkHNd9A@mail.gmail.com>
 <20161025114334.GD3197@potion>
 <CANRm+CwSd7urOU8Crs-jCifApCf8zeDBFqWVqjRNQAD3UgA9fA@mail.gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>, Yunhong Jiang <yunhong.jiang@intel.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <13aa20e8-2931-8817-1d07-7bda8f28fb19@redhat.com>
Date: Wed, 26 Oct 2016 13:15:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <CANRm+CwSd7urOU8Crs-jCifApCf8zeDBFqWVqjRNQAD3UgA9fA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 26 Oct 2016 11:15:48 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1007
Lines: 31



On 26/10/2016 12:23, Wanpeng Li wrote:
>> >
>> >         if (apic_lvtt_oneshot(apic) &&
>> > -           ktime_after(apic->lapic_timer.target_expiration,
>> > -                       apic->lapic_timer.timer.base->get_time())) {
>> > +           !ktime_after(apic->lapic_timer.target_expiration,
>> > +                        apic->lapic_timer.timer.base->get_time())) {
>> >                 apic_timer_expired(apic);
>> >                 return;
>> >         }
>> >
>> > Paolo, can you squash that?
> It seems that squash is impossible since the dependency of current
> kvm/queue(KVM: x86: use ktime_get instead of seeking the
> hrtimer_clock_base), I will send out a separate patch to fix this.

It is squashed in:

+	if (apic_lvtt_oneshot(apic) &&
+	    ktime_after(apic->lapic_timer.timer.base->get_time(),
+			apic->lapic_timer.target_expiration)) {
+		apic_timer_expired(apic);
+		return;
+	}

Notice that the order of the arguments is inverted (alternatively I
could have used ktime_before).

Paolo